You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/04/23 20:06:53 UTC

Review Request 72428: Added intermediate OBJECT library targets for libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72428/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10122
    https://issues.apache.org/jira/browse/MESOS-10122


Repository: mesos


Description
-------

Added intermediate OBJECT library targets for libprocess.


Diffs
-----

  3rdparty/libprocess/src/CMakeLists.txt 6fa1f60ea36424be3888c4e9aee575ab99180486 


Diff: https://reviews.apache.org/r/72428/diff/1/


Testing
-------

`ninja tests && /home/asekretenko/lsyncd/mesos/support/mesos-gtest-runner.py src/mesos-tests` on Linux
`cmake --build . --config Release --target mesos-agent -- -m` on Windows


Thanks,

Andrei Sekretenko


Re: Review Request 72428: Added intermediate OBJECT library targets for libprocess.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72428/#review220476
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72426, 72427, 72428]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 23, 2020, 8:06 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72428/
> -----------------------------------------------------------
> 
> (Updated April 23, 2020, 8:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10122
>     https://issues.apache.org/jira/browse/MESOS-10122
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added intermediate OBJECT library targets for libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt 6fa1f60ea36424be3888c4e9aee575ab99180486 
> 
> 
> Diff: https://reviews.apache.org/r/72428/diff/1/
> 
> 
> Testing
> -------
> 
> `ninja tests && /home/asekretenko/lsyncd/mesos/support/mesos-gtest-runner.py src/mesos-tests` on Linux
> `cmake --build . --config Release --target mesos-agent -- -m` on Windows
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>