You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/21 05:44:42 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12679: Fix #12672: polar data dim is radius
susiwen8 opened a new pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Correct visualMap get wrong data dimension under polar
### Fixed issues
Close #12672
## Details
### Before: What was the problem?
### After: How is it fixed in this PR?
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 closed pull request #12679: Fix #12672: polar data dim is radius
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12679: Fix #12672: polar data dim is radius
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679#issuecomment-646972850
@Ovilia data dim is value dim, so find the right value axis would fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia edited a comment on pull request #12679: Fix #12672: polar data dim is radius
Posted by GitBox <gi...@apache.org>.
Ovilia edited a comment on pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679#issuecomment-645783732
I'm not sure about the way of fixing because it seems the same bug occurs with grid coordinate system.
@susiwen8 Can you check https://gallery.echartsjs.com/editor.html?c=xc80fFTT9a&v=1 to confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12679: Fix #12672: polar data dim is radius
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679#issuecomment-645784173
Ok, I'll check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on pull request #12679: Fix #12672: polar data dim is radius
Posted by GitBox <gi...@apache.org>.
Ovilia commented on pull request #12679:
URL: https://github.com/apache/incubator-echarts/pull/12679#issuecomment-645783732
I'm not sure about the way of fixing because it seems the same bug occurs with [grid](https://gallery.echartsjs.com/editor.html?c=xc80fFTT9a&v=1) coordinate system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org