You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/10/25 07:50:57 UTC

[GitHub] [lucene-solr] jpountz commented on issue #966: LUCENE-9024 Optimize IntroSelector to use median of medians

jpountz commented on issue #966: LUCENE-9024 Optimize IntroSelector to use median of medians
URL: https://github.com/apache/lucene-solr/pull/966#issuecomment-546244507
 
 
   I agree the existing tests should be sufficient since they already check `slowSelect`. Regarding the test issue, I agree that it feels wrong to allocate an array of `from+to+random.nextInt(5)`, it should be `to+random.nextInt(5)`, is it what you are proposing? If yes I'm fine with having it addressed in either this or a follow-up PR, whatever is easier for you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org