You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by snaga <gi...@git.apache.org> on 2017/02/10 04:11:59 UTC
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
GitHub user snaga opened a pull request:
https://github.com/apache/incubator-madlib/pull/100
Fix pom.xml to pass mvn apache-rat:check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snaga/incubator-madlib release
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 582f239d3e176d38d4b98d76aaa67ae8e0e80b44
Author: Satoshi Nagayasu <sn...@uptime.jp>
Date: 2017-02-09T09:31:53Z
Fix to pass mvn apache-rat:check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100577871
--- Diff: pom.xml ---
@@ -643,6 +646,8 @@
<exclude>src/ports/postgres/modules/utilities/admin.py_in</exclude>
<exclude>src/ports/postgres/modules/utilities/control.py_in</exclude>
<exclude>src/ports/postgres/modules/utilities/control_composite.py_in</exclude>
+ <exclude>src/ports/postgres/modules/utilities/create_indicators.py_in</exclude>
+ <exclude>src/ports/postgres/modules/utilities/create_indicators.sql_in</exclude>
<exclude>src/ports/postgres/modules/utilities/data_preparation.py_in</exclude>
--- End diff --
Since we renamed data_preparation to create_indicators, we should remove lines 651 and 652.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100683862
--- Diff: pom.xml ---
@@ -393,6 +395,7 @@
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_2.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3ORCA.cmake</exclude>
+ <exclude>src/ports/greenplum/cmake/FindGreenplum_5.cmake</exclude>
--- End diff --
Hmm. It looks still not having a license header in the master branch.
https://github.com/apache/incubator-madlib/blob/master/src/ports/greenplum/cmake/FindGreenplum_5.cmake
Are we going to add it to this file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100708526
--- Diff: configure ---
@@ -22,6 +22,24 @@ cmake "$@" ..
cd ..
cat <<MAKEFILE >Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
--- End diff --
Yes, you are correct, the makefile is not a part of the artifact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100683876
--- Diff: pom.xml ---
@@ -643,6 +646,8 @@
<exclude>src/ports/postgres/modules/utilities/admin.py_in</exclude>
<exclude>src/ports/postgres/modules/utilities/control.py_in</exclude>
<exclude>src/ports/postgres/modules/utilities/control_composite.py_in</exclude>
+ <exclude>src/ports/postgres/modules/utilities/create_indicators.py_in</exclude>
+ <exclude>src/ports/postgres/modules/utilities/create_indicators.sql_in</exclude>
<exclude>src/ports/postgres/modules/utilities/data_preparation.py_in</exclude>
--- End diff --
I see. Removed exclude tags for data_preparation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #100: Fix pom.xml to pass mvn apache-rat:check.
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on the issue:
https://github.com/apache/incubator-madlib/pull/100
@rvs Thanks for review. Will add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100708801
--- Diff: pom.xml ---
@@ -393,6 +395,7 @@
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_2.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3ORCA.cmake</exclude>
+ <exclude>src/ports/greenplum/cmake/FindGreenplum_5.cmake</exclude>
--- End diff --
Curious, I thought I did add it in one of the prior commits. I'll add it during the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100683912
--- Diff: configure ---
@@ -22,6 +22,24 @@ cmake "$@" ..
cd ..
cat <<MAKEFILE >Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
--- End diff --
Well, this modification intends to add the license header to the Makefile, which is generated by the configure script. But, I guess it is unnecessary for here, because Makefile itself does not exist in the distributed tarball. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100577189
--- Diff: pom.xml ---
@@ -45,6 +45,7 @@
<exclude>ReadMe_Build.txt</exclude>
<exclude>ReleaseNotes.txt</exclude>
<exclude>licenses/**</exclude>
+ <exclude>build/**</exclude>
--- End diff --
Build folder shouldn't be a part of the release so I don't think we need this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100578272
--- Diff: configure ---
@@ -22,6 +22,24 @@ cmake "$@" ..
cd ..
cat <<MAKEFILE >Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
--- End diff --
We should pull the license header to the top of the file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100683866
--- Diff: pom.xml ---
@@ -89,6 +90,7 @@
<exclude>doc/design/modules/crf.tex</exclude>
<exclude>doc/design/modules/decision-trees.tex</exclude>
<exclude>doc/design/modules/glm.tex</exclude>
+ <exclude>doc/design/modules/graph.tex</exclude>
--- End diff --
Removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100578729
--- Diff: pom.xml ---
@@ -393,6 +395,7 @@
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_2.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3.cmake</exclude>
<exclude>src/ports/greenplum/cmake/FindGreenplum_4_3ORCA.cmake</exclude>
+ <exclude>src/ports/greenplum/cmake/FindGreenplum_5.cmake</exclude>
--- End diff --
Since we do have a license header for this file, there is no need to exclude it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100483262
--- Diff: pom.xml ---
@@ -45,6 +45,8 @@
<exclude>ReadMe_Build.txt</exclude>
<exclude>ReleaseNotes.txt</exclude>
<exclude>licenses/**</exclude>
+ <exclude>build/**</exclude>
+ <exclude>Makefile</exclude>
--- End diff --
It is better to add AL header to Makefile rather than this line to pom.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100577548
--- Diff: pom.xml ---
@@ -89,6 +90,7 @@
<exclude>doc/design/modules/crf.tex</exclude>
<exclude>doc/design/modules/decision-trees.tex</exclude>
<exclude>doc/design/modules/glm.tex</exclude>
+ <exclude>doc/design/modules/graph.tex</exclude>
--- End diff --
The license header for this file should be in the master now, there is no need to exclude it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100483457
--- Diff: pom.xml ---
@@ -387,12 +390,14 @@
<exclude>src/ports/greenplum/4.2/CMakeLists.txt</exclude>
<exclude>src/ports/greenplum/4.3/CMakeLists.txt</exclude>
<exclude>src/ports/greenplum/4.3ORCA/CMakeLists.txt</exclude>
+ <exclude>src/ports/greenplum/5/CMakeLists.txt</exclude>
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...
Posted by snaga <gi...@git.apache.org>.
Github user snaga commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/100#discussion_r100683870
--- Diff: pom.xml ---
@@ -45,6 +45,7 @@
<exclude>ReadMe_Build.txt</exclude>
<exclude>ReleaseNotes.txt</exclude>
<exclude>licenses/**</exclude>
+ <exclude>build/**</exclude>
--- End diff --
Removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---