You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/25 15:06:30 UTC

[GitHub] [superset] dvmarkusvogl opened a new pull request #18163: feat: Better extension-fields for docker-compose* + no default names

dvmarkusvogl opened a new pull request #18163:
URL: https://github.com/apache/superset/pull/18163


   ### SUMMARY
   Default container names are already the "-" -> "_" versions of the service names.
   <<: *name can be used to template more efficiently and avoid code duplication
   
   ### TESTING INSTRUCTIONS
   ```
   docker-compose up
   docker-compose -f docker-compose-non-dev.yml up
   ```
   Results in the same as before
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org