You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2012/04/25 01:24:07 UTC
[jira] [Created] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Alejandro Abdelnur created HADOOP-8314:
------------------------------------------
Summary: HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
Key: HADOOP-8314
URL: https://issues.apache.org/jira/browse/HADOOP-8314
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0, 3.0.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Fix For: 2.0.0
Attachments: HADOOP-8314.patch
If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261624#comment-13261624 ]
Hudson commented on HADOOP-8314:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1060 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1060/])
HADOOP-8314. HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated. (tucu) (Revision 1330086)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330086
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Attachment: HADOOP-8314.patch
attaching patch with ATM's suggestion
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261264#comment-13261264 ]
Hudson commented on HADOOP-8314:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2202 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2202/])
HADOOP-8314. HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated. (tucu) (Revision 1330086)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330086
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Attachment: HADOOP-8314_branch-1.patch
patch for branch-1
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Affects Version/s: 1.1.0
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Hadoop Flags: Incompatible change,Reviewed (was: Reviewed)
The incompatible change flag is for branch-1
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Status: Patch Available (was: Open)
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur resolved HADOOP-8314.
----------------------------------------
Resolution: Fixed
committed to branch-1
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261145#comment-13261145 ]
Aaron T. Myers commented on HADOOP-8314:
----------------------------------------
Patch looks pretty good to me, Tucu. One small comment. This should either say either "users are not authorized" or "users are unauthorized" but _not_ "users are not unauthorized". :)
{code}
+ response.sendError(HttpServletResponse.SC_UNAUTHORIZED,
+ "Unauthenticated users are not " +
+ "unauthorized to access this page.");
{code}
Otherwise the patch looks good. +1 pending Jenkins.
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261146#comment-13261146 ]
Hadoop QA commented on HADOOP-8314:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12524080/HADOOP-8314.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/885//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/885//console
This message is automatically generated.
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-8314:
-------------------------------
Fix Version/s: 1.1.0
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0-alpha, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 1.1.0, 2.0.0-alpha
>
> Attachments: HADOOP-8314_branch-1.patch, HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261265#comment-13261265 ]
Hudson commented on HADOOP-8314:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2128 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2128/])
HADOOP-8314. HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated. (tucu) (Revision 1330086)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330086
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur reopened HADOOP-8314:
----------------------------------------
we need backport for branch-1
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Attachment: HADOOP-8314.patch
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261272#comment-13261272 ]
Hudson commented on HADOOP-8314:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2144 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2144/])
HADOOP-8314. HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated. (tucu) (Revision 1330086)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330086
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261610#comment-13261610 ]
Hudson commented on HADOOP-8314:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1025 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1025/])
HADOOP-8314. HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated. (tucu) (Revision 1330086)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330086
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262239#comment-13262239 ]
Aaron T. Myers commented on HADOOP-8314:
----------------------------------------
+1 for the branch-1 patch.
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262149#comment-13262149 ]
Aaron T. Myers commented on HADOOP-8314:
----------------------------------------
Hey Tucu, can you please comment what testing of the branch-1 patch you did? Also, this JIRA will need to be marked as an incompatible change in branch-1.
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262214#comment-13262214 ]
Alejandro Abdelnur commented on HADOOP-8314:
--------------------------------------------
I've run the TestHttpServer testcase that verifies the fix.
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 1.1.0, 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch, HADOOP-8314_branch-1.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8314) HttpServer#hasAdminAccess should
return false if authorization is enabled but user is not authenticated
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8314:
---------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
committed to trunk and branch-2
> HttpServer#hasAdminAccess should return false if authorization is enabled but user is not authenticated
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8314
> URL: https://issues.apache.org/jira/browse/HADOOP-8314
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.0
>
> Attachments: HADOOP-8314.patch, HADOOP-8314.patch
>
>
> If the user is not authenticated (request.getRemoteUser() returns NULL) or there is not authentication filter configured (thus returning also NULL), hasAdminAccess should return false. Note that a filter could allow anonymous access, thus the first case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira