You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "nsnhuang (via GitHub)" <gi...@apache.org> on 2023/06/09 17:07:34 UTC
[GitHub] [doris] nsnhuang opened a new pull request, #20655: [fix] total_time of select_node not include the open phase
nsnhuang opened a new pull request, #20655:
URL: https://github.com/apache/doris/pull/20655
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
add SCOPED_TIMER at the begin of select_node's open function
## Further comments
when using profile text, i found select_node's total_time(active) is smaller than it's child.
By looking at the code，i found that total_time of select_node is not include the open phase.
Based on the above description, I propose the PR. Looking for a response^_^
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20655: [fix] total_time of select_node not include the open phase
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20655:
URL: https://github.com/apache/doris/pull/20655#issuecomment-1585705169
Hi @nsnhuang , thanks for your PR.
Is there also an issue on Master branch? If yes, please submit the PR to master branch.
I will pick it to branch-1.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nsnhuang commented on pull request #20655: [fix] total_time of select_node not include the open phase
Posted by "nsnhuang (via GitHub)" <gi...@apache.org>.
nsnhuang commented on PR #20655:
URL: https://github.com/apache/doris/pull/20655#issuecomment-1585724975
> Hi @nsnhuang , thanks for your PR. Is there also an issue on Master branch? If yes, please submit the PR to master branch. I will pick it to branch-1.2.
Thanks for your response.
I have created pr #20666 . But the master branch only has vselect_node and not has select_node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20655: [fix] total_time of select_node not include the open phase
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20655:
URL: https://github.com/apache/doris/pull/20655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org