You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pavanb018 <gi...@git.apache.org> on 2015/07/09 09:27:52 UTC
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/569
Handling Basic Zone scenarios for starting VM in stopped state
Basic Zone result:
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 41.609s
OK
Advanced Zone result:
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 139.844s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pavanb018/cloudstack regfail
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #569
----
commit 7edbd902ea492c26a2210d2a2e1eef7b21d148db
Author: pavan018 <pa...@gmail.com>
Date: 2015-07-08T05:35:03Z
Changes for Regression failures
commit 861f901be933a76bd6a27e6bc12e0976c44a2a9c
Author: pavan018 <pa...@gmail.com>
Date: 2015-07-09T07:23:27Z
Handling Basic zone failures in startVM with false condition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/569#issuecomment-119887574
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/569#discussion_r34238492
--- Diff: test/integration/component/test_blocker_bugs.py ---
@@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
# all it's services should resume
# Find router associated with user account
- list_router_response = list_routers(
--- End diff --
Since list router vm is getting called multiple time based on zone networking type , can we use a function which list router vm based on networking type .
Please ignore the comment if you feel it is not required .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/569#issuecomment-119913350
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Handling Basic Zone scenarios
for startin...
Posted by Sanjeev N <sa...@apache.org>.
LGTM!! I am taking this patch.
On Thu, Jul 9, 2015 at 3:25 PM, pavanb018 <gi...@git.apache.org> wrote:
> Github user pavanb018 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/569#discussion_r34239937
>
> --- Diff: test/integration/component/test_blocker_bugs.py ---
> @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
> # all it's services should resume
>
> # Find router associated with user account
> - list_router_response = list_routers(
> --- End diff --
>
> We already have the list_routers as wrapper function on top of the api
> building. This function serves basic and advanced zone depending upon the
> passed arguments. Hence the same is called depending on the network type
> check. Adding another function with network type as a parameter might just
> be another wrapper that internally calls list_routers again.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/569#discussion_r34239937
--- Diff: test/integration/component/test_blocker_bugs.py ---
@@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
# all it's services should resume
# Find router associated with user account
- list_router_response = list_routers(
--- End diff --
We already have the list_routers as wrapper function on top of the api building. This function serves basic and advanced zone depending upon the passed arguments. Hence the same is called depending on the network type check. Adding another function with network type as a parameter might just be another wrapper that internally calls list_routers again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---