You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Mick Semb Wever <mc...@apache.org> on 2022/11/01 21:54:10 UTC
Re: Some tests are never executed in CI due to their name
Aha wait a minute I got it :D Yeah. This is not what you invented, it is
> already in, sorry.
>
> So, you are saying we should just modify this to cover @Test / abstract.
>
> I dont know ... interesting.
>
> Lets wait for others to answer.
>
This thread is rather painful to digest because of the top-posting :'(
I agree that all non-abstract classes that contain a @test annotation must
have a filename ending in "Test.java"
That leaves CI scripts untouched.
How we enforce that I have no opinion about. If it's not easy in
checkstyle, just do it with some bash in the cassandra-test.sh script.
It'll get caught pre-commit either way, and once the rename of existing
files is done the precedence is clearly in place.
Re: Some tests are never executed in CI due to their name
Posted by Andrés de la Peña <ad...@apache.org>.
+1 to waiver
On Tue, 15 Nov 2022 at 05:54, Berenguer Blasi <be...@gmail.com>
wrote:
> +1 to waiver
> On 15/11/22 2:07, Josh McKenzie wrote:
>
> +1 to waiver.
>
> We still don't have some kind of @flaky annotation that sequesters tests
> do we? :)
>
> On Mon, Nov 14, 2022, at 5:58 PM, Ekaterina Dimitrova wrote:
>
> +1
>
> On Mon, 14 Nov 2022 at 17:55, Brandon Williams <dr...@gmail.com> wrote:
>
> +1 to waiving these.
>
> On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan <
> Stefan.Miklosovic@netapp.com> wrote:
>
> Tickets for the flaky tests are here
>
> https://issues.apache.org/jira/browse/CASSANDRA-18047
> https://issues.apache.org/jira/browse/CASSANDRA-18048
>
> ________________________________________
> From: Mick Semb Wever <mc...@apache.org>
> Sent: Monday, November 14, 2022 23:28
> To: dev@cassandra.apache.org
> Subject: Re: Some tests are never executed in CI due to their name
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
>
>
>
>
> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
> misunderstanding. We agreed on this thread that we should not commit flaky
> tests right before rc. So now the rc is technically blocked by them. To
> unblock it, what is needed is to have a waiver on them. If there is not a
> waiver, I need to go back to that test and remove the two test methods
> which are flaky. (In practice they will be probably just @Ignore-ed with
> comment about flakiness so we can fix them later).
>
> Flaky tests are
>
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>
>
> +1 to a waiver on these two 4.1 flaky regressions to the RC and GA
> releases.
>
> Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@
> (build/release managers can't be keeping up with every ticket), and dev
> threads and tickets should be kept (reasonably) in-sync, for the sake of
> inclusiveness.
>
> I believe there will be follow up tickets to address these flakies in
> 4.1.x ?
>
>
>
Re: Some tests are never executed in CI due to their name
Posted by Berenguer Blasi <be...@gmail.com>.
+1 to waiver
On 15/11/22 2:07, Josh McKenzie wrote:
> +1 to waiver.
>
> We still don't have some kind of @flaky annotation that sequesters
> tests do we? :)
>
> On Mon, Nov 14, 2022, at 5:58 PM, Ekaterina Dimitrova wrote:
>> +1
>>
>> On Mon, 14 Nov 2022 at 17:55, Brandon Williams <dr...@gmail.com> wrote:
>>
>> +1 to waiving these.
>>
>> On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan
>> <St...@netapp.com> wrote:
>>
>> Tickets for the flaky tests are here
>>
>> https://issues.apache.org/jira/browse/CASSANDRA-18047
>> https://issues.apache.org/jira/browse/CASSANDRA-18048
>>
>> ________________________________________
>> From: Mick Semb Wever <mc...@apache.org>
>> Sent: Monday, November 14, 2022 23:28
>> To: dev@cassandra.apache.org
>> Subject: Re: Some tests are never executed in CI due to their
>> name
>>
>> NetApp Security WARNING: This is an external email. Do not
>> click links or open attachments unless you recognize the
>> sender and know the content is safe.
>>
>>
>>
>>
>> in CASSANDRA-18029, two flaky tests were committed by mistake
>> due to my misunderstanding. We agreed on this thread that we
>> should not commit flaky tests right before rc. So now the rc
>> is technically blocked by them. To unblock it, what is needed
>> is to have a waiver on them. If there is not a waiver, I need
>> to go back to that test and remove the two test methods which
>> are flaky. (In practice they will be probably just @Ignore-ed
>> with comment about flakiness so we can fix them later).
>>
>> Flaky tests are
>>
>> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>>
>>
>> +1 to a waiver on these two 4.1 flaky regressions to the RC
>> and GA releases.
>>
>> Thanks for bringing it back to dev@ Stefan. Waivers should be
>> done on dev@ (build/release managers can't be keeping up with
>> every ticket), and dev threads and tickets should be kept
>> (reasonably) in-sync, for the sake of inclusiveness.
>>
>> I believe there will be follow up tickets to address these
>> flakies in 4.1.x ?
>>
>
Re: Some tests are never executed in CI due to their name
Posted by Josh McKenzie <jm...@apache.org>.
+1 to waiver.
We still don't have some kind of @flaky annotation that sequesters tests do we? :)
On Mon, Nov 14, 2022, at 5:58 PM, Ekaterina Dimitrova wrote:
> +1
>
> On Mon, 14 Nov 2022 at 17:55, Brandon Williams <dr...@gmail.com> wrote:
>> +1 to waiving these.
>>
>> On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan <St...@netapp.com> wrote:
>>> Tickets for the flaky tests are here
>>>
>>> https://issues.apache.org/jira/browse/CASSANDRA-18047
>>> https://issues.apache.org/jira/browse/CASSANDRA-18048
>>>
>>> ________________________________________
>>> From: Mick Semb Wever <mc...@apache.org>
>>> Sent: Monday, November 14, 2022 23:28
>>> To: dev@cassandra.apache.org
>>> Subject: Re: Some tests are never executed in CI due to their name
>>>
>>> NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>>
>>>
>>>
>>>
>>> in CASSANDRA-18029, two flaky tests were committed by mistake due to my misunderstanding. We agreed on this thread that we should not commit flaky tests right before rc. So now the rc is technically blocked by them. To unblock it, what is needed is to have a waiver on them. If there is not a waiver, I need to go back to that test and remove the two test methods which are flaky. (In practice they will be probably just @Ignore-ed with comment about flakiness so we can fix them later).
>>>
>>> Flaky tests are
>>>
>>> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>>> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>>>
>>>
>>> +1 to a waiver on these two 4.1 flaky regressions to the RC and GA releases.
>>>
>>> Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@ (build/release managers can't be keeping up with every ticket), and dev threads and tickets should be kept (reasonably) in-sync, for the sake of inclusiveness.
>>>
>>> I believe there will be follow up tickets to address these flakies in 4.1.x ?
Re: Some tests are never executed in CI due to their name
Posted by Ekaterina Dimitrova <e....@gmail.com>.
+1
On Mon, 14 Nov 2022 at 17:55, Brandon Williams <dr...@gmail.com> wrote:
> +1 to waiving these.
>
> On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan <
> Stefan.Miklosovic@netapp.com> wrote:
>
>> Tickets for the flaky tests are here
>>
>> https://issues.apache.org/jira/browse/CASSANDRA-18047
>> https://issues.apache.org/jira/browse/CASSANDRA-18048
>>
>> ________________________________________
>> From: Mick Semb Wever <mc...@apache.org>
>> Sent: Monday, November 14, 2022 23:28
>> To: dev@cassandra.apache.org
>> Subject: Re: Some tests are never executed in CI due to their name
>>
>> NetApp Security WARNING: This is an external email. Do not click links or
>> open attachments unless you recognize the sender and know the content is
>> safe.
>>
>>
>>
>>
>> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
>> misunderstanding. We agreed on this thread that we should not commit flaky
>> tests right before rc. So now the rc is technically blocked by them. To
>> unblock it, what is needed is to have a waiver on them. If there is not a
>> waiver, I need to go back to that test and remove the two test methods
>> which are flaky. (In practice they will be probably just @Ignore-ed with
>> comment about flakiness so we can fix them later).
>>
>> Flaky tests are
>>
>>
>> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>>
>> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>>
>>
>> +1 to a waiver on these two 4.1 flaky regressions to the RC and GA
>> releases.
>>
>> Thanks for bringing it back to dev@ Stefan. Waivers should be done on
>> dev@ (build/release managers can't be keeping up with every ticket), and
>> dev threads and tickets should be kept (reasonably) in-sync, for the sake
>> of inclusiveness.
>>
>> I believe there will be follow up tickets to address these flakies in
>> 4.1.x ?
>>
>
Re: Some tests are never executed in CI due to their name
Posted by Brandon Williams <dr...@gmail.com>.
+1 to waiving these.
On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan <
Stefan.Miklosovic@netapp.com> wrote:
> Tickets for the flaky tests are here
>
> https://issues.apache.org/jira/browse/CASSANDRA-18047
> https://issues.apache.org/jira/browse/CASSANDRA-18048
>
> ________________________________________
> From: Mick Semb Wever <mc...@apache.org>
> Sent: Monday, November 14, 2022 23:28
> To: dev@cassandra.apache.org
> Subject: Re: Some tests are never executed in CI due to their name
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
>
>
>
>
> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
> misunderstanding. We agreed on this thread that we should not commit flaky
> tests right before rc. So now the rc is technically blocked by them. To
> unblock it, what is needed is to have a waiver on them. If there is not a
> waiver, I need to go back to that test and remove the two test methods
> which are flaky. (In practice they will be probably just @Ignore-ed with
> comment about flakiness so we can fix them later).
>
> Flaky tests are
>
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>
>
> +1 to a waiver on these two 4.1 flaky regressions to the RC and GA
> releases.
>
> Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@
> (build/release managers can't be keeping up with every ticket), and dev
> threads and tickets should be kept (reasonably) in-sync, for the sake of
> inclusiveness.
>
> I believe there will be follow up tickets to address these flakies in
> 4.1.x ?
>
Re: Some tests are never executed in CI due to their name
Posted by "Miklosovic, Stefan" <St...@netapp.com>.
Tickets for the flaky tests are here
https://issues.apache.org/jira/browse/CASSANDRA-18047
https://issues.apache.org/jira/browse/CASSANDRA-18048
________________________________________
From: Mick Semb Wever <mc...@apache.org>
Sent: Monday, November 14, 2022 23:28
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
in CASSANDRA-18029, two flaky tests were committed by mistake due to my misunderstanding. We agreed on this thread that we should not commit flaky tests right before rc. So now the rc is technically blocked by them. To unblock it, what is needed is to have a waiver on them. If there is not a waiver, I need to go back to that test and remove the two test methods which are flaky. (In practice they will be probably just @Ignore-ed with comment about flakiness so we can fix them later).
Flaky tests are
org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
+1 to a waiver on these two 4.1 flaky regressions to the RC and GA releases.
Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@ (build/release managers can't be keeping up with every ticket), and dev threads and tickets should be kept (reasonably) in-sync, for the sake of inclusiveness.
I believe there will be follow up tickets to address these flakies in 4.1.x ?
Re: Some tests are never executed in CI due to their name
Posted by Mick Semb Wever <mc...@apache.org>.
> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
> misunderstanding. We agreed on this thread that we should not commit flaky
> tests right before rc. So now the rc is technically blocked by them. To
> unblock it, what is needed is to have a waiver on them. If there is not a
> waiver, I need to go back to that test and remove the two test methods
> which are flaky. (In practice they will be probably just @Ignore-ed with
> comment about flakiness so we can fix them later).
>
> Flaky tests are
>
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>
+1 to a waiver on these two 4.1 flaky regressions to the RC and GA releases.
Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@
(build/release managers can't be keeping up with every ticket), and dev
threads and tickets should be kept (reasonably) in-sync, for the sake of
inclusiveness.
I believe there will be follow up tickets to address these flakies in
4.1.x ?
Re: Some tests are never executed in CI due to their name
Posted by "Miklosovic, Stefan" <St...@netapp.com>.
Hi list,
in CASSANDRA-18029, two flaky tests were committed by mistake due to my misunderstanding. We agreed on this thread that we should not commit flaky tests right before rc. So now the rc is technically blocked by them. To unblock it, what is needed is to have a waiver on them. If there is not a waiver, I need to go back to that test and remove the two test methods which are flaky. (In practice they will be probably just @Ignore-ed with comment about flakiness so we can fix them later).
Flaky tests are
org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
I sincerely apologize for messing things up and being drifted away by the ticket and forgetting about the ML thread which has the ultimate precedence in this matter. This should have been ideally requested before the commit and it was just an oversight about keeping both ticket and ML communication in sync.
Regards
________________________________________
From: Brandon Williams <dr...@gmail.com>
Sent: Thursday, November 10, 2022 13:20
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
+1 to treating as new unvetted tests.
Kind Regards,
Brandon
On Thu, Nov 10, 2022 at 5:41 AM Mick Semb Wever <mc...@apache.org> wrote:
>
>
>
> On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan <St...@netapp.com> wrote:
>>
>> I want to ask if people are comfortable with merging CASSANDRA-17964 before 4.1 is out. We clean a lot of things and rename tests which we should take care of. (like PaxosRepairTest2).
>>
>> We might still fix it without merging 17964 as we know what should be fixed and we can wait until 4.1 is out but I personally do not see any reason for this.
>
>
>
> Unless these are runtime failures that will hurt users running 4.1, let's treat them as new incomplete tests. So please let's not add new broken tests right before the rc.
Re: Some tests are never executed in CI due to their name
Posted by Brandon Williams <dr...@gmail.com>.
+1 to treating as new unvetted tests.
Kind Regards,
Brandon
On Thu, Nov 10, 2022 at 5:41 AM Mick Semb Wever <mc...@apache.org> wrote:
>
>
>
> On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan <St...@netapp.com> wrote:
>>
>> I want to ask if people are comfortable with merging CASSANDRA-17964 before 4.1 is out. We clean a lot of things and rename tests which we should take care of. (like PaxosRepairTest2).
>>
>> We might still fix it without merging 17964 as we know what should be fixed and we can wait until 4.1 is out but I personally do not see any reason for this.
>
>
>
> Unless these are runtime failures that will hurt users running 4.1, let's treat them as new incomplete tests. So please let's not add new broken tests right before the rc.
Re: Some tests are never executed in CI due to their name
Posted by Mick Semb Wever <mc...@apache.org>.
On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan <
Stefan.Miklosovic@netapp.com> wrote:
> I want to ask if people are comfortable with merging CASSANDRA-17964
> before 4.1 is out. We clean a lot of things and rename tests which we
> should take care of. (like PaxosRepairTest2).
>
> We might still fix it without merging 17964 as we know what should be
> fixed and we can wait until 4.1 is out but I personally do not see any
> reason for this.
>
Unless these are runtime failures that will hurt users running 4.1, let's
treat them as new incomplete tests. So please let's not add new broken
tests right before the rc.
Re: Some tests are never executed in CI due to their name
Posted by "Miklosovic, Stefan" <St...@netapp.com>.
I want to ask if people are comfortable with merging CASSANDRA-17964 before 4.1 is out. We clean a lot of things and rename tests which we should take care of. (like PaxosRepairTest2).
We might still fix it without merging 17964 as we know what should be fixed and we can wait until 4.1 is out but I personally do not see any reason for this.
Thoughts?
________________________________________
From: Miklosovic, Stefan <St...@netapp.com>
Sent: Monday, November 7, 2022 23:23
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
Hi,
A while ago we came up with a very nice solution (thank you David Capwell for suggesting this). Sorry for no updating this thread sooner, a lot of discussion was done in the ticket. (CASSANDRA-17964).
The solution we think is the best is to have an Ant task which would scan all classes via reflection on build-test target (separate / dedicated target will be available too) and it will scan files on containing Test annotation. If that annotation is present, it means that class is a test and it has to have so and so naming convention (currently it has to end on Test). There are details covered as well (for example, cases when there is an abstract class containing all @Test methods and a concrete test class is just extending that, all is covered too).
The reason for this approach is that:
1) it is way more robust that trying to come up with some super regexp
2) We can put arbitrary logic into it, for example, we may ignore the invalid name of a test class if we "know what we are doing" but putting @IgnoreInvalidTestName annotation on top of that class and Ant task would just skip that.
3) We can introduce this task into all branches we support. Checkstyle is present only in 4.1 and trunk so we would have kind of half-baked solution here and older branches would not be covered.
As we enabled more tests because they were ignored / effectively skipped previously, some enabled tests started to fail. There are two (currently know):
(1) This one started to fail on 4.0, not sure whats the deal for older branches, it probably needs deeper look
(2) PaxorRepairTest2 - this one fails to start because of configuration in that test but even it is fixed it fails anyway on something else. I will create a ticket for that soon.
I will reference this email to Cassandra update status to raise awareness that some tests we enabled started to fail in 4.0 -> trunk.
1) https://issues.apache.org/jira/browse/CASSANDRA-18021
2) ticket to be created
Thanks
________________________________________
From: Berenguer Blasi <be...@gmail.com>
Sent: Thursday, November 3, 2022 9:47
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Re '@Test' without 'abstract': There's a corner case of a base abstract class with all test cases. Then 2 or 3 inheriting classes with no '@Test' annotations bc they just run the base class with different configs, setups, envs, parametrized runs, etc I've seen some of those.
On 1/11/22 22:54, Mick Semb Wever wrote:
Aha wait a minute I got it :D Yeah. This is not what you invented, it is already in, sorry.
So, you are saying we should just modify this to cover @Test / abstract.
I dont know ... interesting.
Lets wait for others to answer.
This thread is rather painful to digest because of the top-posting :'(
I agree that all non-abstract classes that contain a @test annotation must have a filename ending in "Test.java"
That leaves CI scripts untouched.
How we enforce that I have no opinion about. If it's not easy in checkstyle, just do it with some bash in the cassandra-test.sh script. It'll get caught pre-commit either way, and once the rename of existing files is done the precedence is clearly in place.
Re: Some tests are never executed in CI due to their name
Posted by "Miklosovic, Stefan" <St...@netapp.com>.
Hi,
A while ago we came up with a very nice solution (thank you David Capwell for suggesting this). Sorry for no updating this thread sooner, a lot of discussion was done in the ticket. (CASSANDRA-17964).
The solution we think is the best is to have an Ant task which would scan all classes via reflection on build-test target (separate / dedicated target will be available too) and it will scan files on containing Test annotation. If that annotation is present, it means that class is a test and it has to have so and so naming convention (currently it has to end on Test). There are details covered as well (for example, cases when there is an abstract class containing all @Test methods and a concrete test class is just extending that, all is covered too).
The reason for this approach is that:
1) it is way more robust that trying to come up with some super regexp
2) We can put arbitrary logic into it, for example, we may ignore the invalid name of a test class if we "know what we are doing" but putting @IgnoreInvalidTestName annotation on top of that class and Ant task would just skip that.
3) We can introduce this task into all branches we support. Checkstyle is present only in 4.1 and trunk so we would have kind of half-baked solution here and older branches would not be covered.
As we enabled more tests because they were ignored / effectively skipped previously, some enabled tests started to fail. There are two (currently know):
(1) This one started to fail on 4.0, not sure whats the deal for older branches, it probably needs deeper look
(2) PaxorRepairTest2 - this one fails to start because of configuration in that test but even it is fixed it fails anyway on something else. I will create a ticket for that soon.
I will reference this email to Cassandra update status to raise awareness that some tests we enabled started to fail in 4.0 -> trunk.
1) https://issues.apache.org/jira/browse/CASSANDRA-18021
2) ticket to be created
Thanks
________________________________________
From: Berenguer Blasi <be...@gmail.com>
Sent: Thursday, November 3, 2022 9:47
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Re '@Test' without 'abstract': There's a corner case of a base abstract class with all test cases. Then 2 or 3 inheriting classes with no '@Test' annotations bc they just run the base class with different configs, setups, envs, parametrized runs, etc I've seen some of those.
On 1/11/22 22:54, Mick Semb Wever wrote:
Aha wait a minute I got it :D Yeah. This is not what you invented, it is already in, sorry.
So, you are saying we should just modify this to cover @Test / abstract.
I dont know ... interesting.
Lets wait for others to answer.
This thread is rather painful to digest because of the top-posting :'(
I agree that all non-abstract classes that contain a @test annotation must have a filename ending in "Test.java"
That leaves CI scripts untouched.
How we enforce that I have no opinion about. If it's not easy in checkstyle, just do it with some bash in the cassandra-test.sh script. It'll get caught pre-commit either way, and once the rename of existing files is done the precedence is clearly in place.
Re: Some tests are never executed in CI due to their name
Posted by Berenguer Blasi <be...@gmail.com>.
Re '@Test' without 'abstract': There's a corner case of a base abstract
class with all test cases. Then 2 or 3 inheriting classes with no
'@Test' annotations bc they just run the base class with different
configs, setups, envs, parametrized runs, etc I've seen some of those.
On 1/11/22 22:54, Mick Semb Wever wrote:
>
>
> Aha wait a minute I got it :D Yeah. This is not what you invented,
> it is already in, sorry.
>
> So, you are saying we should just modify this to cover @Test /
> abstract.
>
> I dont know ... interesting.
>
> Lets wait for others to answer.
>
>
>
> This thread is rather painful to digest because of the top-posting :'(
>
> I agree that all non-abstract classes that contain a @test annotation
> must have a filename ending in "Test.java"
>
> That leaves CI scripts untouched.
>
> How we enforce that I have no opinion about. If it's not easy in
> checkstyle, just do it with some bash in the cassandra-test.sh script.
> It'll get caught pre-commit either way, and once the rename of
> existing files is done the precedence is clearly in place.