[jira] [Created] (ARROW-14436) [C++] Disable color diagnostics when compiling with ccache

["Krisztian Szucs (Jira)" <ji...@apache.org>]

Krisztian Szucs created ARROW-14436:
---------------------------------------

             Summary: [C++] Disable color diagnostics when compiling with ccache
                 Key: ARROW-14436
                 URL: https://issues.apache.org/jira/browse/ARROW-14436
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Krisztian Szucs
             Fix For: 7.0.0


Copied from https://github.com/apache/arrow/issues/11279

Steps to reproduce:

Compile arrow_objlib with ccache, clang and CCACHE_DEBUG=1 CCACHE_LOGFILE=./ccache.log
Find in ./ccache.log:
Failed; falling back to running the real compiler
Result: unsupported compiler option
Dropping -fcolor-diagnostics fixes the issue.

I suggest either opting into color diagnostics with WITH_COLOR_DIAGNOSTICS or adding a way to disable it via DISABLE_COLOR_DIAGNOSTICS.
It would be good if this wouldn't be tied to ARROW_USE_CCACHE since its also relevant for:
-DARROW_USE_CCACHE=OFF -DCMAKE_CXX_COMPILER_LAUNCHER=emscripten_ccache.

I can open a PR if you tell me which way you prefer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)