You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "umartin (via GitHub)" <gi...@apache.org> on 2023/02/17 19:44:52 UTC

[GitHub] [sedona] umartin opened a new pull request, #772: [SEDONA-249] Add jvm flags for running tests on Java 17

umartin opened a new pull request, #772:
URL: https://github.com/apache/sedona/pull/772

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-249. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   Add jvm flags to test plugins to make it possible to run tests on Java 17. This will make life easier for contributors running Java 17 locally.
   
   This PR does not add Java 17 to the test matrix for github actions.
   This PR does not make the tests pass on Java 17. Currently CRSTransformationTest.testPolygonDistanceJoinWithCRSTransformation in sedona-core fails on Java 17.
   
   ## How was this patch tested?
   
   All tests pass on Java 8.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #772:
URL: https://github.com/apache/sedona/pull/772#issuecomment-1435176063

   @umartin Thanks for bringing this up. Interestingly, I found CRSTransformationTest.testPolygonDistanceJoinWithCRSTransformation also failed on Java 11. I haven't figured why. Any idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] umartin commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

Posted by "umartin (via GitHub)" <gi...@apache.org>.
umartin commented on PR #772:
URL: https://github.com/apache/sedona/pull/772#issuecomment-1435226458

   I think there was a patch in a point release of Java 11 that changed the string representation of floats. For me it fails on Java 11.0.17 although I remember it passing on earlier version of Java 11. It the test reads geometries from csv files they could be interpreted differently depending on java version.
   
   I remember tweaking some tests in sedona-sql when that change hit me. https://github.com/apache/sedona/blob/master/sql/src/test/scala/org/apache/sedona/sql/functionTestScala.scala#L163
   
   The test runs a distance join in RDD with polygons. The Circle geometry is only valid for points. Maybe the test can be removed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #772:
URL: https://github.com/apache/sedona/pull/772#issuecomment-1435323043

   @umartin Yes! Can you remove that flaky test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu merged pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #772:
URL: https://github.com/apache/sedona/pull/772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] umartin commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

Posted by "umartin (via GitHub)" <gi...@apache.org>.
umartin commented on PR #772:
URL: https://github.com/apache/sedona/pull/772#issuecomment-1435654795

   @jiayuasu No problem! I added a commit removing the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org