[GitHub] [incubator-superset] rusackas commented on a change in pull request #10982: refactor: Replace reactable with DataTable from superset-ui in ChangeDatasourceModal

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10982:
URL: https://github.com/apache/incubator-superset/pull/10982#discussion_r496281453



##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -600,3 +600,55 @@ input[type='radio']:checked:after {
 hr {
   border-top: 1px solid @gray-light;
 }
+
+.modal-fullscreen {
+  & > .modal-lg {
+    height: calc(100% - 60px);
+    & > .modal-content {
+      height: 100%;
+      display: flex;
+      flex-direction: column;
+      & > .modal-body {
+        display: flex;
+        flex-direction: column;
+        flex: 1;
+      }
+    }
+  }
+}
+
+.flex-1 {

Review comment:
       Is there a reason not to have this just be part of the .sticky-table class?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org