You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/11/20 06:36:01 UTC

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags
URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910635
 
 

 ##########
 File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto
 ##########
 @@ -112,6 +112,7 @@ message AddRequest {
     required int64 entryId = 2;
     required bytes masterKey = 3;
     required bytes body = 4;
+    optional int64 writeFlags = 5;
 
 Review comment:
   are we planning to use 8 bytes? probably just int32?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services