You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "pantianying (GitHub)" <gi...@apache.org> on 2019/12/30 03:31:12 UTC
[GitHub] [dubbo-go] pantianying opened pull request #292: optimize
code style
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/292 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #292: optimize code
style
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=h1) Report
> Merging [#292](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #292 +/- ##
===========================================
+ Coverage 66.56% 66.58% +0.01%
===========================================
Files 112 112
Lines 7175 7173 -2
===========================================
Hits 4776 4776
+ Misses 1935 1932 -3
- Partials 464 465 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/292/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19maWx0ZXIuZ28=) | `67.69% <0%> (+2.02%)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/292/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/292/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/292/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/292/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=footer). Last update [382169c...b74bb2f](https://codecov.io/gh/apache/dubbo-go/pull/292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/292 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] pantianying closed pull request #292: optimize
code style
Posted by "pantianying (GitHub)" <gi...@apache.org>.
[ pull request closed by pantianying ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/292 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org