You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Michael Ivanov <iv...@logit-ag.de> on 2015/10/27 10:09:11 UTC
Possible typo in messenger.c?
Hallo,
Is this an error:
if (messenger->flags | PN_FLAGS_CHECK_ROUTES) {
. . . .
}
(line 1498 in messenger.c)?
Shouldn't it be:
if (messenger->flags & PN_FLAGS_CHECK_ROUTES) {
Or do I miss sthing?
Best regards,
--
\ / | |
(OvO) | Mikhail Iwanow |
(^^^) | Voice: +7 (911) 223-1300 |
\^/ | E-mail: ivans@logit-ag.de |
^ ^ | |
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org
Re: Possible typo in messenger.c?
Posted by aconway <ac...@redhat.com>.
On Tue, 2015-10-27 at 12:09 +0300, Michael Ivanov wrote:
> Hallo,
>
> Is this an error:
>
> if (messenger->flags | PN_FLAGS_CHECK_ROUTES) {
> . . . .
> }
>
> (line 1498 in messenger.c)?
>
> Shouldn't it be:
>
> if (messenger->flags & PN_FLAGS_CHECK_ROUTES) {
>
> Or do I miss sthing?
>
Well spotted. As it is, it will always do the check regardless of the
flag setting. I would go ahead and fix it but I'm not a big messenger
user - fixing this would mean that if you haven't set the flag the
route check will no longer happen, could this be a problem for existing
messenger apps?
Cheers,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org