[GitHub] sohami commented on a change in pull request #1434: DRILL-6694: NPE in UnnestRecordBatch when query uses a column name no…

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1434: DRILL-6694: NPE in UnnestRecordBatch when query uses a column name no…
URL: https://github.com/apache/drill/pull/1434#discussion_r210759060
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
 ##########
 @@ -62,6 +62,8 @@
   private int remainderIndex = 0;
   private int recordCount;
   private MaterializedField unnestFieldMetadata;
+  // Reference of TypedFieldId for Unnest column. It's always set in schemaChanged method and later used by others
+  private TypedFieldId unnestTypedFieldId;
 
 Review comment:
   kept a reference of it here since it's costly to get it everytime from incoming batch based on column name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services