You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/19 08:31:23 UTC
[GitHub] [camel-k] squakez opened a new pull request #2583: feat(trait): container image pull policy
squakez opened a new pull request #2583:
URL: https://github.com/apache/camel-k/pull/2583
Closes #2503
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a change in pull request #2583: feat(trait): container image pull policy
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #2583:
URL: https://github.com/apache/camel-k/pull/2583#discussion_r692002664
##########
File path: pkg/trait/container.go
##########
@@ -74,12 +74,12 @@ type containerTrait struct {
ServicePort int `property:"service-port" json:"servicePort,omitempty"`
// To configure under which service port name the container port is to be exposed (default `http`).
ServicePortName string `property:"service-port-name" json:"servicePortName,omitempty"`
-
// The main container name. It's named `integration` by default.
Name string `property:"name" json:"name,omitempty"`
// The main container image
Image string `property:"image" json:"image,omitempty"`
-
+ // The pull policy: Always|Never|IfNotPresent
+ ImagePullPolicy string `property:"image-pull-policy" json:"imagePullPolicy,omitempty"`
Review comment:
Yes, it's cleaner this way. I've committed the changes, please have a further look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2583: feat(trait): container image pull policy
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2583:
URL: https://github.com/apache/camel-k/pull/2583#discussion_r691941398
##########
File path: pkg/trait/container.go
##########
@@ -74,12 +74,12 @@ type containerTrait struct {
ServicePort int `property:"service-port" json:"servicePort,omitempty"`
// To configure under which service port name the container port is to be exposed (default `http`).
ServicePortName string `property:"service-port-name" json:"servicePortName,omitempty"`
-
// The main container name. It's named `integration` by default.
Name string `property:"name" json:"name,omitempty"`
// The main container image
Image string `property:"image" json:"image,omitempty"`
-
+ // The pull policy: Always|Never|IfNotPresent
+ ImagePullPolicy string `property:"image-pull-policy" json:"imagePullPolicy,omitempty"`
Review comment:
I wonder if the `corev1.PullPolicy` type could be used directly here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #2583: feat(trait): container image pull policy
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2583:
URL: https://github.com/apache/camel-k/pull/2583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org