You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lokeshj1703 (via GitHub)" <gi...@apache.org> on 2024/11/28 15:41:23 UTC
[PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
lokeshj1703 opened a new pull request, #12363:
URL: https://github.com/apache/hudi/pull/12363
### Change Logs
Currently AND operator can allow other operators like OR and allow to filter records. We need to disallow the behavior as it can lead to some records not getting filtered. Ideally for other unsupported operators it should not filter any records.
### Impact
NA
### Risk level (write none, low medium or high below)
low
### Documentation Update
NA
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #12363:
URL: https://github.com/apache/hudi/pull/12363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12363:
URL: https://github.com/apache/hudi/pull/12363#issuecomment-2506394318
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84bca1e08f9c0099d37dcc60057ff5687a83bab8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12363:
URL: https://github.com/apache/hudi/pull/12363#issuecomment-2506509465
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2059",
"triggerID" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84bca1e08f9c0099d37dcc60057ff5687a83bab8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2059)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #12363:
URL: https://github.com/apache/hudi/pull/12363#discussion_r1862861696
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/RecordLevelIndexSupport.scala:
##########
@@ -25,8 +25,8 @@ import org.apache.hudi.common.model.FileSlice
import org.apache.hudi.common.model.HoodieRecord.HoodieMetadataField
import org.apache.hudi.common.model.HoodieTableQueryType.SNAPSHOT
import org.apache.hudi.common.table.HoodieTableMetaClient
-import org.apache.hudi.common.table.timeline.InstantComparison.compareTimestamps
import org.apache.hudi.common.table.timeline.InstantComparison
+import org.apache.hudi.common.table.timeline.InstantComparison.compareTimestamps
Review Comment:
The import is used in the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12363:
URL: https://github.com/apache/hudi/pull/12363#issuecomment-2506397127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2059",
"triggerID" : "84bca1e08f9c0099d37dcc60057ff5687a83bab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84bca1e08f9c0099d37dcc60057ff5687a83bab8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2059)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8598] Fix AND operator to not filter unsupported query types [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #12363:
URL: https://github.com/apache/hudi/pull/12363#discussion_r1862659471
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/RecordLevelIndexSupport.scala:
##########
@@ -25,8 +25,8 @@ import org.apache.hudi.common.model.FileSlice
import org.apache.hudi.common.model.HoodieRecord.HoodieMetadataField
import org.apache.hudi.common.model.HoodieTableQueryType.SNAPSHOT
import org.apache.hudi.common.table.HoodieTableMetaClient
-import org.apache.hudi.common.table.timeline.InstantComparison.compareTimestamps
import org.apache.hudi.common.table.timeline.InstantComparison
+import org.apache.hudi.common.table.timeline.InstantComparison.compareTimestamps
Review Comment:
remove any unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org