You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@edgent.apache.org by dj...@apache.org on 2016/05/05 19:53:13 UTC
[1/2] incubator-quarks git commit: Remove State.fromString() as enums
always have the valueOf method
Repository: incubator-quarks
Updated Branches:
refs/heads/master 4c2e6d96c -> fa48c5f06
Remove State.fromString() as enums always have the valueOf method
Project: http://git-wip-us.apache.org/repos/asf/incubator-quarks/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quarks/commit/144e1bdf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quarks/tree/144e1bdf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quarks/diff/144e1bdf
Branch: refs/heads/master
Commit: 144e1bdf8d75602e3f43033956e223a9f1152bf1
Parents: 9589cc0
Author: Dan Debrunner <dj...@debrunners.com>
Authored: Thu May 5 10:39:31 2016 -0700
Committer: Dan Debrunner <dj...@debrunners.com>
Committed: Thu May 5 10:39:31 2016 -0700
----------------------------------------------------------------------
.../java/quarks/execution/mbeans/JobMXBean.java | 22 --------------------
.../runtime/etiao/mbeans/EtiaoJobBean.java | 4 ++--
2 files changed, 2 insertions(+), 24 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quarks/blob/144e1bdf/api/execution/src/main/java/quarks/execution/mbeans/JobMXBean.java
----------------------------------------------------------------------
diff --git a/api/execution/src/main/java/quarks/execution/mbeans/JobMXBean.java b/api/execution/src/main/java/quarks/execution/mbeans/JobMXBean.java
index 14d22a1..f1bc5e9 100644
--- a/api/execution/src/main/java/quarks/execution/mbeans/JobMXBean.java
+++ b/api/execution/src/main/java/quarks/execution/mbeans/JobMXBean.java
@@ -42,28 +42,6 @@ public interface JobMXBean {
PAUSED,
/** All the graph nodes are closed. */
CLOSED;
-
- /**
- * Converts from a string representation of a job status to the corresponding enumeration value.
- *
- * @param state specifies a job status string value.
- *
- * @return the corresponding {@code Status} enumeration value.
- *
- * @throws IllegalArgumentException if the input string does not map to an enumeration value.
- * @throws NullPointerException if the input value is null.
- */
- static public State fromString(String state) {
- if (state == null) {
- throw new NullPointerException("state");
- }
- for (State value : State.values()) {
- if (value.name().equals(state)) {
- return value;
- }
- }
- throw new IllegalArgumentException(state);
- }
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-quarks/blob/144e1bdf/runtime/etiao/src/main/java/quarks/runtime/etiao/mbeans/EtiaoJobBean.java
----------------------------------------------------------------------
diff --git a/runtime/etiao/src/main/java/quarks/runtime/etiao/mbeans/EtiaoJobBean.java b/runtime/etiao/src/main/java/quarks/runtime/etiao/mbeans/EtiaoJobBean.java
index 6fcafd1..69ae5ce 100644
--- a/runtime/etiao/src/main/java/quarks/runtime/etiao/mbeans/EtiaoJobBean.java
+++ b/runtime/etiao/src/main/java/quarks/runtime/etiao/mbeans/EtiaoJobBean.java
@@ -46,12 +46,12 @@ public class EtiaoJobBean implements JobMXBean {
@Override
public State getCurrentState() {
- return State.fromString(job.getCurrentState().name());
+ return State.valueOf(job.getCurrentState().name());
}
@Override
public State getNextState() {
- return State.fromString(job.getNextState().name());
+ return State.valueOf(job.getNextState().name());
}
@Override
[2/2] incubator-quarks git commit: Merge branch 'pr-108'
Posted by dj...@apache.org.
Merge branch 'pr-108'
Project: http://git-wip-us.apache.org/repos/asf/incubator-quarks/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quarks/commit/fa48c5f0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quarks/tree/fa48c5f0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quarks/diff/fa48c5f0
Branch: refs/heads/master
Commit: fa48c5f06b56ccf3a761dfb3b69bf01f626b78f1
Parents: 4c2e6d9 144e1bd
Author: Daniel J. Debrunner <de...@us.ibm.com>
Authored: Thu May 5 12:53:38 2016 -0700
Committer: Daniel J. Debrunner <de...@us.ibm.com>
Committed: Thu May 5 12:53:38 2016 -0700
----------------------------------------------------------------------
.../java/quarks/execution/mbeans/JobMXBean.java | 22 --------------------
.../runtime/etiao/mbeans/EtiaoJobBean.java | 4 ++--
2 files changed, 2 insertions(+), 24 deletions(-)
----------------------------------------------------------------------