You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 13:44:11 UTC

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2421: net/neighbor/neighbor_ethernet_out.c: fix build error without ICMPv6

juniskane opened a new pull request #2421:
URL: https://github.com/apache/incubator-nuttx/pull/2421


   ## Summary
   
   Patch fixes following build error when
   CONFIG_NET_IPv6 && !CONFIG_NET_ICMPv6 && CONFIG_NET_ETHERNET:
   
     nuttx/staging/libnet.a(neighbor_ethernet_out.o): In function `neighbor_ethernet_out':
     nuttx/net/neighbor/neighbor_ethernet_out.c:188: undefined reference to `icmpv6_solicit'
   
   IPv6 without ICMPv6 is not very useful, but at least this patch
   allows neighbor_ethernet_out() to be used with a packet socket or
   with multicast address (point-to-point IPv6 links) even in that case.
   
   ## Impact
   
   ## Testing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] juniskane commented on pull request #2421: net/neighbor/neighbor_ethernet_out.c: fix build error without ICMPv6

Posted by GitBox <gi...@apache.org>.
juniskane commented on pull request #2421:
URL: https://github.com/apache/incubator-nuttx/pull/2421#issuecomment-734842979


   It tried hard to think of some way for reporting the error back to upper layers instead of DEBUGPANIC(), but could not find a good way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2421: net/neighbor/neighbor_ethernet_out.c: fix build error without ICMPv6

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2421:
URL: https://github.com/apache/incubator-nuttx/pull/2421


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org