[jira] [Commented] (HBASE-17599) Also set the partial flag of Result to true if we reach the batch limit

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853540#comment-15853540 ] 

stack commented on HBASE-17599:
-------------------------------

Patch LGTM. +1.

bq. But for scan.setBatch(xx), the partial result returned will not be marked as partial.

Presumption was that we'd not get a partial result when we setBatch?

Worth a page in the parent that lists all the nice fixups?

> Also set the partial flag of Result to true if we reach the batch limit
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17599
>                 URL: https://issues.apache.org/jira/browse/HBASE-17599
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17599.patch
>
>
> For now if we set scan.allowPartial(true), the partial result returned will have the partial flag set to true. But for scan.setBatch(xx), the partial result returned will not be marked as partial.
> This is an Incompatible change, indeed. But I do not think it will introduce any issues as we just provide more informations to client. The old partial flag for batched scan is always false so I do not think anyone can make use of it.
> This is very important for the limited scan to support partial results from server. If we get a Result which partial flag is false then we know we get the whole row. Otherwise we need to fetch one more row to see if the row key is changed which causes the logic to be more complicated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)