You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/08 06:46:40 UTC

[GitHub] [rocketmq-spring] rainsoft opened a new issue, #444: Add default consumer namespace to DefaultRocketMQListenerContainer

rainsoft opened a new issue, #444:
URL: https://github.com/apache/rocketmq-spring/issues/444

   The issue tracker is **ONLY** used for bug report and feature request. 
   
   Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/).
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
         2.2.2版本添加了namespace配置，但是对于@RocketMQMessageListener，需要在每个注解中设置namespace，
   能否通过rocketmq.consumer.namespace设置默认的namespace？
   
   2. Provide any additional detail on your proposed use case for this feature.
   `    private DefaultRocketMQListenerContainer createRocketMQListenerContainer(String name, Object bean,
           RocketMQMessageListener annotation) {
                 ......
           container.setMessageConverter(rocketMQMessageConverter.getMessageConverter());
           container.setName(name);
   
           // set default namespace
           String namespace = rocketMQProperties.getConsumer().getNamespace();
           if (StringUtils.isEmpty(container.getNamespace()) && !StringUtils.isEmpty(namespace)) {
               container.setNamespace(namespace);
           }
   
           return container;
       }`
   
   5. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
          should-have


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] zhouhai22 commented on issue #444: Add default consumer namespace to DefaultRocketMQListenerContainer

Posted by GitBox <gi...@apache.org>.
zhouhai22 commented on issue #444:
URL: https://github.com/apache/rocketmq-spring/issues/444#issuecomment-1220099981

   I only add the default namespace for consumer, not both producer and consumer, which may not works well. I will test it, if there are any questions, I will submit another PR to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] panzhi33 closed issue #444: Add default consumer namespace to DefaultRocketMQListenerContainer

Posted by GitBox <gi...@apache.org>.
panzhi33 closed issue #444: Add default consumer namespace to DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/issues/444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] panzhi33 commented on issue #444: Add default consumer namespace to DefaultRocketMQListenerContainer

Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #444:
URL: https://github.com/apache/rocketmq-spring/issues/444#issuecomment-1160129891

   namespace is used for logical isolation. If a default value is set for namespace, the actual resource will become namespace%topic or namespace%group, which is not friendly to users of rocketmq who are not familiar with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org