[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

[jpeach <gi...@git.apache.org>]

Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/272#issuecomment-147929606
  
    *TSHttpTxnApplyLogFormat*
    
    - I think the name could be clearer, maybe TSHttpTxnFormatLogTags() or TSHttpFormatTags().
    - It seems reasonable to format to an IO buffer, but if you think
      you would like to also be able to format to a pre-allocated buffer
      (pointer + length), we should choose the right name now so that
      later they will name sense.
    
    *TSHttpTxnErrorBodyBufferSet*
    
    - The description text doesn't seem to match.
    - Since this is clearly intended to be paired with the log formatter,
      it would be helpful to explicitly join the dots in the description.
    - I don't think you need the MIME type argument since it is easy
      to set the Content-Type header using existing API. If you think
      the existing API is too troublesome, maybe a secondary helper API
      that can set a named header?
    
    You should go ahead and commit the TSIOBufferReaderAlloc man page,
    but call it TSIOBufferReader since it is documenting the whole API
    family (which makes sense).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---