[GitHub] [hudi] nsivabalan commented on a diff in pull request #5269: [HUDI-3636] Create new write clients for async table services in DeltaStreamer

[GitBox <gi...@apache.org>]

nsivabalan commented on code in PR #5269:
URL: https://github.com/apache/hudi/pull/5269#discussion_r995223267


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncCompactService.java:
##########
@@ -78,13 +81,26 @@ protected Pair<CompletableFuture, ExecutorService> startService() {
 
         while (!isShutdownRequested()) {
           final HoodieInstant instant = fetchNextAsyncServiceInstant();
-
           if (null != instant) {
             LOG.info("Starting Compaction for instant " + instant);
+            synchronized (writeConfigUpdateLock) {

Review Comment:
   we can't cancel existing async service if its inflight. And so we might have to create N such instances and need to find a way to clean those up. Wouldn't this be easier than that. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org