[jira] [Closed] (CLOUDSTACK-6249) Modified QoS of VIF Code not working

["Yitao Jiang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yitao Jiang closed CLOUDSTACK-6249.
-----------------------------------

    Resolution: Not A Problem

Sorry ,guys.
It's my mistake.
I set up two mgmt server, and forget to sync the codes to each other.
Forgive me.

> Modified QoS of VIF Code not working
> ------------------------------------
>
>                 Key: CLOUDSTACK-6249
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6249
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Hypervisor Controller, Xen
>    Affects Versions: 4.2.1
>         Environment: CS 4.2.1 runs on CenOS 6.3
> Xenserver 6.2.0
>            Reporter: Yitao Jiang
>             Fix For: 4.2.1
>
>
> In CirtixResourceBase.java(https://github.com/apache/cloudstack/blob/4.2.1/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java) of createVif method , i see that the network rate value will be multiplied by 128 .
> 	if (nic.getNetworkRateMbps() != null
> 				&& nic.getNetworkRateMbps().intValue() != -1) {
> 			vifr.qosAlgorithmType = "ratelimit";
> 			vifr.qosAlgorithmParams = new HashMap<String, String>();
> 			// convert mbs to kilobyte per second
> 			vifr.qosAlgorithmParams.put("kbps",
> 					Integer.toString(nic.getNetworkRateMbps() * 128));
> 			
> 		}
> and when i create a service_offering with 1Mb/s QoS, the vm's networking will be limited in 128Kb/s.
> All works fine.
> But what i wanna do is when a service_offering with 1Mb/s then the vm will be limited in 1Kb/s,so I change the coded like that 
>                             vifr.qosAlgorithmParams.put("kbps",
> 					Integer.toString(nic.getNetworkRateMbps()));
> without multiplied by 128.
> After spawn a vm with 1Mb/s QoS servicing offering, through the xencenter the networking limit still 128.
> Do you guys know why , did i miss anything?



--
This message was sent by Atlassian JIRA
(v6.2#6252)