[jira] Commented: (THRIFT-589) Add Field Name to Field ID Mapping

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761620#action_12761620 ] 

Bryan Duxbury commented on THRIFT-589:
--------------------------------------

This generally looks pretty good. I would like to see you generate the map with the FIELD_NAME constants instead of the ids directly, though.

> Add Field Name to Field ID Mapping
> ----------------------------------
>
>                 Key: THRIFT-589
>                 URL: https://issues.apache.org/jira/browse/THRIFT-589
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Cyrus Katrak
>         Attachments: thrift589-2.patch, thrift589.patch
>
>
> The reflection stuff in java thrift is quite useful, but to use it you must know the field id (not the name) of the field you are working with.
> Given a field name, you can obtain the corresponding ID by iterating through the metaDataMap, but it's not ideal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.