You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/09/14 13:27:23 UTC
Review Request 25620: Expect less fields in messages in
falcon-regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25620/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-726
https://issues.apache.org/jira/browse/FALCON-726
Repository: falcon-git
Description
-------
We used to get some fields from ActiveMQ during retention that are not present now:
"topicName" -> "FALCON." + feedName
"brokerImplClass" - > "org.apache.activemq.ActiveMQConnectionFactory"
"brokerUrl" -> activeMQUrl
Now topicName can be verified via getJMSDestination().
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java d113554
Diff: https://reviews.apache.org/r/25620/diff/
Testing
-------
RetentionTest.testRetention()
Thanks,
Ruslan Ostafiychuk
Re: Review Request 25620: Expect less fields in messages in
falcon-regression
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25620/#review53295
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Sept. 14, 2014, 4:27 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25620/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2014, 4:27 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-726
> https://issues.apache.org/jira/browse/FALCON-726
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> We used to get some fields from ActiveMQ during retention that are not present now:
> "topicName" -> "FALCON." + feedName
> "brokerImplClass" - > "org.apache.activemq.ActiveMQConnectionFactory"
> "brokerUrl" -> activeMQUrl
> Now topicName can be verified via getJMSDestination().
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java d113554
>
> Diff: https://reviews.apache.org/r/25620/diff/
>
>
> Testing
> -------
>
> RetentionTest.testRetention()
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>