[GitHub] [flink] pnowojski commented on a change in pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #16429:
URL: https://github.com/apache/flink/pull/16429#discussion_r666031058



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
##########
@@ -410,7 +402,7 @@ public WatermarkContext(
         }
 
         @Override
-        public void collect(T element) {
+        public final void collect(T element) {
             checkNotClosed();

Review comment:
       As I can see, `checkNotClosed()` was always called here on all of the code paths, so for example `processAndCollect` was calling it at least twice in the end? One time directly and the other time indirectly via this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org