You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/22 14:04:56 UTC
[GitHub] [pulsar] momo-jun opened a new pull request, #16746: [improve][doc] Improve the description of acknowledgment timeout in Java docs and REST links
momo-jun opened a new pull request, #16746:
URL: https://github.com/apache/pulsar/pull/16746
### Modifications
1. Fix #16695 - improve the description of acknowledgment timeout in Java docs
2. Fix incorrect REST API links or add anchors to land on a specific REST API for doc versions 2.7.x.
### Documentation
- [ ] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16746: [improve][doc] Improve the description of acknowledgment timeout in Java docs and REST API links
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16746:
URL: https://github.com/apache/pulsar/pull/16746#discussion_r944494668
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -181,9 +181,11 @@
* Set the timeout for unacked messages, truncated to the nearest millisecond. The timeout needs to be greater than
* 1 second.
*
- * <p>By default, the acknowledge timeout is disabled and that means that messages delivered to a
- * consumer is not re-delivered unless the consumer crashes. Since 2.3.0, when a dead letter policy
- * is specified, and no ackTimeoutMillis is specified, the ack timeout is set to 30 seconds.
+ * <p>By default, the acknowledge timeout is disabled (set to ‘0’ which means no limit).
+ * When a consumer with an infinite acknowledgment timeout terminates, any unacknowledged
+ * messages that it receives are re-delivered to another consumer.
+ * Since 2.3.0, when a dead letter policy is specified and no ackTimeoutMillis is specified,
+ * the ack timeout is set to 30 seconds.
Review Comment:
Yes, it can be used. I've attached the screenshot in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16746: [improve][doc] Improve the description of acknowledgment timeout in Java docs and REST API links
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16746:
URL: https://github.com/apache/pulsar/pull/16746#discussion_r941949896
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -181,9 +181,11 @@
* Set the timeout for unacked messages, truncated to the nearest millisecond. The timeout needs to be greater than
* 1 second.
*
- * <p>By default, the acknowledge timeout is disabled and that means that messages delivered to a
- * consumer is not re-delivered unless the consumer crashes. Since 2.3.0, when a dead letter policy
- * is specified, and no ackTimeoutMillis is specified, the ack timeout is set to 30 seconds.
+ * <p>By default, the acknowledge timeout is disabled (set to ‘0’ which means no limit).
+ * When a consumer with an infinite acknowledgment timeout terminates, any unacknowledged
+ * messages that it receives are re-delivered to another consumer.
+ * Since 2.3.0, when a dead letter policy is specified and no ackTimeoutMillis is specified,
+ * the ack timeout is set to 30 seconds.
Review Comment:
Have you run checks to test line 184-188? Can we use ’’ in code description? What does the preview look like？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16746: [improve][doc] Improve the description of acknowledgment timeout in Java docs and REST API links
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16746:
URL: https://github.com/apache/pulsar/pull/16746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16746: [improve][doc] Improve the description of acknowledgment timeout in Java docs and REST API links
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16746:
URL: https://github.com/apache/pulsar/pull/16746#issuecomment-1209212298
Ping @RobertIndie @Anonymitaet for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org