svn_cmdline_init

[Ben Collins-Sussman <su...@collab.net>]

I just noticed we have an svn_cmdline_init().  Apparently it calls
apr_initialize(), sets the locale, and sets the error stream.

In cmdline/main.c(), we call this func at line 565.  But further down,
we call svn_config_ensure (line 828).  There's a big comment above
that call, wishing it were folded into another function.  Perhaps it
should move into svn_cmdline_init()?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn_cmdline_init

[cm...@collab.net]

Ben Collins-Sussman <su...@collab.net> writes:

> I just noticed we have an svn_cmdline_init().  Apparently it calls
> apr_initialize(), sets the locale, and sets the error stream.
> 
> In cmdline/main.c(), we call this func at line 565.  But further down,
> we call svn_config_ensure (line 828).  There's a big comment above
> that call, wishing it were folded into another function.  Perhaps it
> should move into svn_cmdline_init()?

I don't think so.  svn_cmdline_init() is (or should be) used by all
our commandline apps (svn, svnadmin, svnlook, etc).  But we don't
necessary want all of those to ensure that you have a ~/.subversion
area.  svnlook, for example, doesn't need such a thing.  I can't
recall if svnadmin does or not.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org