You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2023/06/01 06:49:22 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #9586: feat: docker image creation from local codebase
shreemaan-abhishek opened a new pull request, #9586:
URL: https://github.com/apache/apisix/pull/9586
### Description
Support creation of docker image from local codebase.
Fixes #9541
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] An-DJ commented on pull request #9586: feat: docker image creation from local codebase
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581768811
👍 Nice work !
Is it packaged into both amd64 and arm arch docker image, right?
Then mac user could set up their dev environment easily : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9586: feat: docker image creation from local codebase
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581867431
@monkeyDluffy6017 good idea, thanks for the review 🙏🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9586: feat: docker image creation from local codebase
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581926196
@monkeyDluffy6017 @An-DJ please review: https://github.com/apache/apisix-docker/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9586: feat: docker image creation from local codebase
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1580437435
It looks great, Setting up APISIX is a bit complicated, but the all steps are in the https://github.com/apache/apisix/blob/master/ci/linux_openresty_common_runner.sh.
We could follow that step by step.
This file is hard to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9586: feat: docker image creation from local codebase
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581805145
> So i think we could do this in https://github.com/apache/apisix-docker, create a docker image for development when we release apisix.
The idea is to create docker images of the local codebase. If we shift this PR to the `apisix-docker` repository I don't think the creation of docker images of the local codebase can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9586: feat: docker image creation from local codebase
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581809654
> Is it packaged into both amd64 and arm arch docker image, right?
It uses apisix-base:dev as the base docker image, so in theory, the created docker image should be of the same CPU architecture as the host machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9586: feat: docker image creation from local codebase
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9586:
URL: https://github.com/apache/apisix/pull/9586#issuecomment-1581836527
> > So i think we could do this in https://github.com/apache/apisix-docker, create a docker image for development when we release apisix.
>
> The idea is to create docker images of the local codebase. If we shift this PR to the `apisix-docker` repository I don't think the creation of docker images of the local codebase can be done.
We'd better not do this in the main apisix repository, maybe you could put your files to [apisix-docker](https://github.com/apache/apisix-docker) and add instructions for use to in [build-apisix](https://apisix.apache.org/docs/apisix/next/building-apisix/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek closed pull request #9586: feat: docker image creation from local codebase
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek closed pull request #9586: feat: docker image creation from local codebase
URL: https://github.com/apache/apisix/pull/9586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org