[GitHub] [couchdb] iilyak opened a new pull request #3752: Port 3286

[GitBox <gi...@apache.org>]

iilyak opened a new pull request #3752:
URL: https://github.com/apache/couchdb/pull/3752


   ## Overview
   
   The main purpose of this PR is to port https://github.com/apache/couchdb/pull/3286 to 3.x. Which adds ability to run elixir suite against already running instance of CouchDB. However due to various changes to underlying build infrastructure few other commits and PRs were added into the mix.
   
   - https://github.com/apache/couchdb/pull/3286
   - https://github.com/apache/couchdb/pull/3415
   - Extract support for `--erlang-config` flag from https://github.com/apache/couchdb/commit/fff07ba136cfa7433647e974355068b43e63199c 
   
   There were couple of fixup to make test suite pass
   
   - 3.x uses `Code.require_file` to inject `partition_helpers.exs` and `reshard_helpers.exs`. The original implementation of `Couch.Test.Suite` in [#3286](https://github.com/apache/couchdb/pull/3286) didn't support test helpers. 
   - I found a bug in state management of `ensure_exunit_started()` function. We used `Process.gett/2` instead of `Process.put/2` (see [`ensure_exunit_started()`](https://github.com/apache/couchdb/pull/3286/files#diff-50bb8399a196ad15a8f066b1eb5d95930c15b362737ccefbdaf3d4a2663ea397R156)).
   - few elixir tests were added to `main` without updating `test/elixir/test/config/suite.elixir`
   
   ## Testing recommendations
   
   1 Make sure that tests discovery works
   ```
   MIX_ENV=integration mix build
   MIX_ENV=integration mix suite
   ```
   2 Make sure the tests run and pass by using `make elixir-suite`
   
   
   ## Related Issues or Pull Requests
   
   - https://github.com/apache/couchdb/pull/3286
   - https://github.com/apache/couchdb/pull/3415
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak merged pull request #3752: Port 3286 - Add ability to control which Elixir integration tests to run

[GitBox <gi...@apache.org>]

iilyak merged pull request #3752:
URL: https://github.com/apache/couchdb/pull/3752


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org