You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/14 03:43:42 UTC
[GitHub] [servicecomb-java-chassis] Nick-The-Uncharted opened a new pull
request #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or
higher with log4j2
Nick-The-Uncharted opened a new pull request #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue
#1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher
with log4j2
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-599008341
[](https://coveralls.io/builds/29348650)
Coverage decreased (-0.04%) to 84.826% when pulling **03137634a7238ac2c422562f4861d00d46c7d99d on Nick-The-Uncharted:master** into **15cb6a740e5a106e9fc6b577f7b26b365ddbd4db on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1632:
[SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-599822924
Thanks for this fix. Because there are some [pending issues](https://issues.apache.org/jira/browse/SCB-1738) need to handle for working with higher versions of JDK, need find a better solution for this.
As I know, this fix is because java-chassis using Marker to log invocation data, while log4j2 designed Marker to be static data, thus cause OOM. This usage may not be correct. So we need to find a better solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] Nick-The-Uncharted commented on issue
#1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher
with log4j2
Posted by GitBox <gi...@apache.org>.
Nick-The-Uncharted commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-599910479
I am not familiar with higher version of JDK, do you mean better solution that not using reflection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] Nick-The-Uncharted closed pull request
#1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher
with log4j2
Posted by GitBox <gi...@apache.org>.
Nick-The-Uncharted closed pull request #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1632:
[SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-600522989
I submit a PR for this : https://github.com/apache/servicecomb-java-chassis/pull/1642/files
Please add your review comments if some problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1632:
[SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-600060422
> I am not familiar with higher version of JDK, do you mean better solution that not using reflection?
Yes. I am thinking some others ways to adress this problem tomorrow. The recent PR has removed log4j2 fixs to a seperate module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1632:
[SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-599008341
[](https://coveralls.io/builds/29348595)
Coverage decreased (-0.03%) to 84.835% when pulling **03137634a7238ac2c422562f4861d00d46c7d99d on Nick-The-Uncharted:master** into **15cb6a740e5a106e9fc6b577f7b26b365ddbd4db on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] Nick-The-Uncharted commented on issue
#1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher
with log4j2
Posted by GitBox <gi...@apache.org>.
Nick-The-Uncharted commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-600528932
@liubao68 Your PR use MDC instead of Marker to trace user, I dont actully use marker to filter logs so this seems okay to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services