You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "paul8263 (via GitHub)" <gi...@apache.org> on 2023/02/10 06:53:27 UTC
[GitHub] [flink-connector-kafka] paul8263 opened a new pull request, #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
paul8263 opened a new pull request, #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5
… results in Null Pointer Exception
This PR is the migration from [FLINK-25916](https://github.com/apache/flink/pull/20343)
# What is the purpose of the change
Allow flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.WrappedContext to set timestamp with NULL value in order to avoid NPE.
# Brief change log
- flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java
- flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriterTest.java
# Verifying this change
This change is already covered by existing tests, such as flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriterTest::testWriteDataWithNullTimestamp().
# Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with @Public(Evolving): no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
# Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] MartijnVisser commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1493824389
> Could you please help approve the workflow? It seems that the CI process won't run anymore.
The new ASF guidelines require approval from a committer to run a CI flow; I've just started it for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mhv666 commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "mhv666 (via GitHub)" <gi...@apache.org>.
mhv666 commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1480884379
Hi @jaumebecks, I'm waiting as well for any updates 🙏🏽 Thanks guys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1487370775
Changes LGTM, +1 to @Gerrrr's comment on extending `UpsertKafkaTableITCase` before we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] jaumebecks commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "jaumebecks (via GitHub)" <gi...@apache.org>.
jaumebecks commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1469700247
Hi! Any update on this? Is there anything we can do to support this issue? @paul8263 @MartijnVisser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] paul8263 commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "paul8263 (via GitHub)" <gi...@apache.org>.
paul8263 commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1493499385
Hi @tzulitai ，
Could you please help approve the workflow? It seems that the CI process won't run anymore.
I tried pushing the same commit to both this project and the legacy Flink project, but I got different errors. May take some time to figure it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai closed pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai closed pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
URL: https://github.com/apache/flink-connector-kafka/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mhv666 commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "mhv666 (via GitHub)" <gi...@apache.org>.
mhv666 commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1431318313
on the previous PR the reviewers were @mas-chen @MartijnVisser and @zentol if you can add it will be great 💪🏽
Thanks a lot @paul8263 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1489307778
@paul8263 I think you can just go to the CI job page and re-run the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1483388583
Hey folks @paul8263 @jaumebecks @mhv666, I can try to review this next week after some other work - will need a bit of time to catch up. Thanks for the patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1425273961
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] paul8263 commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…
Posted by "paul8263 (via GitHub)" <gi...@apache.org>.
paul8263 commented on PR #5:
URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1488252488
Hi @tzulitai ，
Thank you for reviewing the code.
After adding some tests in `UpsertKafkaTableITCase` I got some exceptions like: javax.management.InstanceAlreadyExistsException.
As GitHub CI page scroll is laggy, I pushed the same codes to Flink project and got hive-connector compilation failure, which is weird.
How could I rerun the unit tests and solve those errors? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org