You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/07 22:02:21 UTC

[GitHub] OldPanda commented on issue #4295: AIRFLOW-3452 removed an unused/dangerous display-none

OldPanda commented on issue #4295: AIRFLOW-3452 removed an unused/dangerous display-none
URL: https://github.com/apache/incubator-airflow/pull/4295#issuecomment-445379605
 
 
   I don't think this is a right fix to the ticket. As mentioned by @ashb , the `style="display:none;"` is overwritten somewhere (probably [here](https://github.com/apache/incubator-airflow/blob/master/airflow/www_rbac/templates/airflow/dags.html#L306), I'm not a frontend expert). 
   
   Also, the issue of empty `/home` page  could be fixed by https://github.com/apache/incubator-airflow/blob/master/CONTRIBUTING.md#setting-up-the-node--npm-javascript-environment-only-for-www_rbac

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services