You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 20:39:08 UTC
[GitHub] [spark] huaxingao opened a new pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
huaxingao opened a new pull request #30063:
URL: https://github.com/apache/spark/pull/30063
### What changes were proposed in this pull request?
Add case sensitivity tests for column resolution in ALTER TABLE
### Why are the changes needed?
To make sure `spark.sql.caseSensitive` works for `ResolveAlterTableChanges`
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
new test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709671969
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34467/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709580974
**[Test build #129855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129855/testReport)** for PR 30063 at commit [`52f0613`](https://github.com/apache/spark/commit/52f06139a6c80334185dc0ed6e164eee7221bed4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709670397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709671979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30063:
URL: https://github.com/apache/spark/pull/30063#discussion_r505914686
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -318,4 +319,69 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(msg.contains("Table not found"))
}
}
+
+ test("ALTER TABLE case sensitivity") {
+ withTable("h2.test.alt_table") {
+ sql("CREATE TABLE h2.test.alt_table (c1 INTEGER NOT NULL, c2 INTEGER) USING _")
+ var t = spark.table("h2.test.alt_table")
+ var expectedSchema = new StructType().add("c1", IntegerType).add("c2", IntegerType)
+ assert(t.schema === expectedSchema)
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table RENAME COLUMN C2 TO c3")
+ }.getMessage
+ assert(msg.contains("Cannot rename missing field C2 in test.alt_table schema"))
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ sql("ALTER TABLE h2.test.alt_table RENAME COLUMN C2 TO c3")
+ expectedSchema = new StructType().add("c1", IntegerType).add("c3", IntegerType)
+ t = spark.table("h2.test.alt_table")
+ assert(t.schema === expectedSchema)
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table DROP COLUMN C3")
+ }.getMessage
+ assert(msg.contains("Cannot delete missing field C3 in test.alt_table schema"))
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ sql("ALTER TABLE h2.test.alt_table DROP COLUMN C3")
+ expectedSchema = new StructType().add("c1", IntegerType)
+ t = spark.table("h2.test.alt_table")
+ assert(t.schema === expectedSchema)
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table ALTER COLUMN C1 TYPE DOUBLE")
Review comment:
indentation?
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -318,4 +319,69 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(msg.contains("Table not found"))
}
}
+
+ test("ALTER TABLE case sensitivity") {
+ withTable("h2.test.alt_table") {
+ sql("CREATE TABLE h2.test.alt_table (c1 INTEGER NOT NULL, c2 INTEGER) USING _")
+ var t = spark.table("h2.test.alt_table")
+ var expectedSchema = new StructType().add("c1", IntegerType).add("c2", IntegerType)
+ assert(t.schema === expectedSchema)
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table RENAME COLUMN C2 TO c3")
+ }.getMessage
+ assert(msg.contains("Cannot rename missing field C2 in test.alt_table schema"))
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ sql("ALTER TABLE h2.test.alt_table RENAME COLUMN C2 TO c3")
+ expectedSchema = new StructType().add("c1", IntegerType).add("c3", IntegerType)
+ t = spark.table("h2.test.alt_table")
+ assert(t.schema === expectedSchema)
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table DROP COLUMN C3")
+ }.getMessage
+ assert(msg.contains("Cannot delete missing field C3 in test.alt_table schema"))
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ sql("ALTER TABLE h2.test.alt_table DROP COLUMN C3")
+ expectedSchema = new StructType().add("c1", IntegerType)
+ t = spark.table("h2.test.alt_table")
+ assert(t.schema === expectedSchema)
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table ALTER COLUMN C1 TYPE DOUBLE")
+ }.getMessage
+ assert(msg.contains("Cannot update missing field C1 in test.alt_table schema"))
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ sql("ALTER TABLE h2.test.alt_table ALTER COLUMN C1 TYPE DOUBLE")
+ expectedSchema = new StructType().add("c1", DoubleType)
+ t = spark.table("h2.test.alt_table")
+ assert(t.schema === expectedSchema)
+ }
+
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
+ val msg = intercept[AnalysisException] {
+ sql("ALTER TABLE h2.test.alt_table ALTER COLUMN C1 DROP NOT NULL")
Review comment:
indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709604605
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30063:
URL: https://github.com/apache/spark/pull/30063#discussion_r505915141
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -318,4 +319,69 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(msg.contains("Table not found"))
}
}
+
+ test("ALTER TABLE case sensitivity") {
+ withTable("h2.test.alt_table") {
Review comment:
Although I understand this is the patter in this suite, let's declare a variable for this string and reuse it in this new test case, @huaxingao .
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -318,4 +319,69 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(msg.contains("Table not found"))
}
}
+
+ test("ALTER TABLE case sensitivity") {
+ withTable("h2.test.alt_table") {
Review comment:
Although I understand this is the pattern in this suite, let's declare a variable for this string and reuse it in this new test case, @huaxingao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709791516
**[Test build #129861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129861/testReport)** for PR 30063 at commit [`aee4d88`](https://github.com/apache/spark/commit/aee4d88443874236350c87f7cea86d2ee2191c16).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709653971
@dongjoon-hyun Thanks for the comments! I have updated the code. Please take another check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709580974
**[Test build #129855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129855/testReport)** for PR 30063 at commit [`52f0613`](https://github.com/apache/spark/commit/52f06139a6c80334185dc0ed6e164eee7221bed4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709669670
**[Test build #129855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129855/testReport)** for PR 30063 at commit [`52f0613`](https://github.com/apache/spark/commit/52f06139a6c80334185dc0ed6e164eee7221bed4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709696744
Thanks! @dongjoon-hyun @HyukjinKwon
FYI @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709667174
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34467/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709671979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30063:
URL: https://github.com/apache/spark/pull/30063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709653848
**[Test build #129861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129861/testReport)** for PR 30063 at commit [`aee4d88`](https://github.com/apache/spark/commit/aee4d88443874236350c87f7cea86d2ee2191c16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709653848
**[Test build #129861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129861/testReport)** for PR 30063 at commit [`aee4d88`](https://github.com/apache/spark/commit/aee4d88443874236350c87f7cea86d2ee2191c16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709611109
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709670397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709792902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709792902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709611122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709685548
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30063: [SPARK-32402][SQL][FOLLOW-UP] Add case sensitivity tests for column resolution in ALTER TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30063:
URL: https://github.com/apache/spark/pull/30063#issuecomment-709611122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org