You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/23 15:46:34 UTC

[GitHub] [spark] gatorsmile commented on a change in pull request #24640: [SPARK-27770] [SQL] Port AGGREGATES.sql [Part 1]

gatorsmile commented on a change in pull request #24640: [SPARK-27770] [SQL]  Port AGGREGATES.sql [Part 1]
URL: https://github.com/apache/spark/pull/24640#discussion_r287013014
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ##########
 @@ -109,7 +109,7 @@ trait CheckAnalysis extends PredicateHelper {
 
         operator transformExpressionsUp {
           case a: Attribute if !a.resolved =>
-            val from = operator.inputSet.map(_.qualifiedName).mkString(", ")
+            val from = operator.inputSet.toSeq.map(_.qualifiedName).mkString(", ")
 
 Review comment:
   This minor fix is to improve the error messages. It does not worth a separate PR. I removed [TEST]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org