You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/20 16:33:37 UTC
[GitHub] [cordova-plugin-device] breautek opened a new pull request #143: doc: Noted android quirks on uuid property
breautek opened a new pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Docs
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Closes https://github.com/apache/cordova-plugin-device/issues/111
### Description
<!-- Describe your changes in detail -->
Added notes on the `uuid` property for android and why it now returns `UNKNOWN`.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek edited a comment on pull request #143: doc: Noted android quirks on serial property
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143#issuecomment-923124865
Initial version of this PR had marked quirks on `uuid` property, but the actual property in question is actually `serial`. I was confused with the two properties. `uuid` property should still be usable. The `serial` property will always return `UNKNOWN` now, unless if the application have special privileged permissions, only available to phone manufacturers and/or carriers.
I've since changed and corrected this PR to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek commented on pull request #143: doc: Noted android quirks on serial property
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143#issuecomment-923124865
Initial version of this PR had marked quirks on `uuid` property, but the actual property in question is actually `serial`. I was confused with the two properties. `uuid` property should still be usable. The `serial` property will always return `UNKNOWN` now, unless if the application have special privileged permissions, only available to phone manufacturers and/or carriers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek merged pull request #143: doc: Noted android quirks on serial property
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] NiklasMerz commented on a change in pull request #143: doc: Noted android quirks on serial property
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143#discussion_r712714830
##########
File path: README.md
##########
@@ -262,3 +262,6 @@ var string = device.serial;
- Android
- OSX
+### Android Quirk
+
+As of Android 9, the underlying native API that powered the `uuid` property is deprecated and will always return `UNKNOWN` without proper permissions. Cordova have never implemented handling the required permissions. As of Android 10, **all** non-resettable is no longer readable by normal applications and will always return `UNKNOWN`. More information can be [read here](https://developer.android.com/about/versions/10/privacy/changes#non-resettable-device-ids).
Review comment:
```suggestion
As of Android 9, the underlying native API that powered the `uuid` property is deprecated and will always return `UNKNOWN` without proper permissions. Cordova have never implemented handling the required permissions. As of Android 10, **all** non-resettable device identifiers are no longer readable by normal applications and will always return `UNKNOWN`. More information can be [read here](https://developer.android.com/about/versions/10/privacy/changes#non-resettable-device-ids).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek commented on pull request #143: doc: Noted android quirks on serial property
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #143:
URL: https://github.com/apache/cordova-plugin-device/pull/143#issuecomment-926654292
Corrected the grammar error, thanks for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org