You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by rajith attapattu <ra...@gmail.com> on 2014/05/29 17:21:20 UTC

Review Request 22022: [PROTON-589] Implementation to support passive mode for proton-j messenger

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22022/
-----------------------------------------------------------

Review request for qpid and Rafael Schloming.


Bugs: PROTON-589
    https://issues.apache.org/jira/browse/PROTON-589


Repository: qpid


Description
-------

This patch contains the first draft of the implementation for passive mode.

1. Changed the messenger to use the collector API instead of the querying API.
2. Removed dependency on the driver code.
3. Added NIO based implementation for non passive mode.


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1598317 

Diff: https://reviews.apache.org/r/22022/diff/


Testing
-------

This version of the patch fails 6 python based tests.
No tests yet for passive mode.
Passive mode needs to be tested thoroughly.

The purpose of this review is to get agreement about the direction I have taken.


Thanks,

rajith attapattu