You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "liujiacheng777 (via GitHub)" <gi...@apache.org> on 2023/03/30 09:44:53 UTC
[GitHub] [arrow] liujiacheng777 opened a new pull request, #34793: GH-34792: [C++]Add support for LoongArch
liujiacheng777 opened a new pull request, #34793:
URL: https://github.com/apache/arrow/pull/34793
[double-conversion/utils.h] has been modified individually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1511018915
@kou should we reopen this one? It seems a prerequisite for https://github.com/apache/arrow/pull/34740 and its purpose seems to be to integrate in the vendored double-conversion https://github.com/google/double-conversion/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1492321053
Oops, missed that this was closed. My mistake :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1490910124
See also: https://github.com/apache/arrow/pull/14817
It's for `cpp/src/arrow/vendored/fast_float/` not `cpp/src/arrow/vendored/double-conversion/` but it should be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34793: GH-34792: [C++]Add support for LoongArch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1490008442
* Closes: #34792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] loongson-zn commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "loongson-zn (via GitHub)" <gi...@apache.org>.
loongson-zn commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1491198565
Update double-conversion latest release, not a single file. @liujiacheng777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1490907992
> [double-conversion/utils.h] has been modified individually
Don't do this.
Please update `cpp/src/arrow/vendored/double-conversion/` entirely to the latest release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1511024079
We don't need to reopen this because we have #34919.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liujiacheng777 closed pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "liujiacheng777 (via GitHub)" <gi...@apache.org>.
liujiacheng777 closed pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
URL: https://github.com/apache/arrow/pull/34793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34793: GH-34792: [C++]Add support for LoongArch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34793:
URL: https://github.com/apache/arrow/pull/34793#issuecomment-1490008523
:warning: GitHub issue #34792 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #34793: ARROW-34792: [C++] Update vendored double-conversion
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on code in PR #34793:
URL: https://github.com/apache/arrow/pull/34793#discussion_r1154723086
##########
cpp/src/arrow/vendored/double-conversion/README.md:
##########
@@ -1,20 +0,0 @@
-<!---
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
--->
-
-The files in this directory are vendored from double-conversion git tag v3.1.5.
Review Comment:
We should update this readme instead of deleting it.
##########
cpp/src/arrow/vendored/double-conversion/CMakeLists.txt:
##########
@@ -1,18 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-arrow_install_all_headers("arrow/vendored/double-conversion")
Review Comment:
Wouldn't we still need this?
##########
cpp/src/arrow/vendored/double-conversion/SConscript:
##########
@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-
+double_conversion_sources = [
Review Comment:
What is this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org