You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/29 12:37:38 UTC
[GitHub] [royale-asjs] estanglerbm opened a new pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
estanglerbm opened a new pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960
Fix VerifyError: Error #1053 in Flash Debug Player due to wrong IDataInput / IDataOutput used in mx.messaging.messages.* classes, and due to mismatch of IFactory type between spark.components.DataGroup and IItemRendererProvider.
For mx.messaging.messages.*, the conditional imports for IDataInput / IDataOutput (for IExternalizable) used elsewhere were not used here. The compiler didn't complain.
For DataGroup, there is a problem that it defines set/get itemRenderer with mx.core.IFactory, but it's implementing IItemRendererProvider that uses org.apache.royale.core.IFactory. This is hard to reconcile, so I used SWFOverride. (FYI, mx.controls.listClasses.ListBase uses org.apache.royale.core.IFactory when implementing IItemRendererProvider, so there's some inconsistency.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] greg-dove commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
greg-dove commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735914501
> Hi @greg-dove could you take a look to this PR?
> Thanks in advance for your help on this
Sorry all, I can't look into this more deeply until this coming weekend earliest. But the Fixes for IDataInput/IDataOutput seem correct to me.
This situation with swf was probably overlooked because I was verifying Royale JS against Flex builds and not against swf builds of the same thing in Royale for actual remoting tests. (For all the low level tests with AMFBinaryData, that is done with both swf and JS in Royale.)
The need for dual imports is valid here, because there are interfaces with method signatures that have arguments that reference other native interfaces in their types in swf, so you can't really 'override' them. Even if it was possible, the effort to make all this 'one' single api to avoid the conditional imports is IMO not worth it. Probably the swf stubs that I added thinking I could do that should be removed, so it is not confusing, but I'm just musing without spending time checking to see.... I can look into it more on of after this next weekend, or if others want to look at that earlier, please go for it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs merged pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
Harbs merged pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735682966
Hi @greg-dove could you take a look to this PR?
Thanks in advance for your help on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735945436
I merged it for now. @greg-dove Please see if there's another way to go about this when you have a chance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735695883
I don't see any harm in this change, but I'm concerned that it's needed.
`org.apache.royale.utils.net.IDataInput` extends `flash.utils.IDataInput` in the `SWF` compile, so I would not think you'd get mismatched types. If there are mismatched types, it feels like it should be fixed in `org.apache.royale.utils.net`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] estanglerbm commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types
Posted by GitBox <gi...@apache.org>.
estanglerbm commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735711686
Everywhere else that IDataInput / IDataOutput is used, there are conditional imports. It was just missed in this area, as far as I can tell. So this isn't something new.
Flex doesn't allow function overloading like you describe; it throws `Error: Incompatible override.`
That is, it doesn't allow:
```
package a
{
public class Y {}
public class X extends Y {}
public class B { public function foo(c:Y):void {} }
public class A extends B { override public function foo(c:X):void {} }
}
```
The IDataInput / IDataOutput changes are just copying over the conditional imports from other areas.
The DataGroup change is something new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org