You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/09/16 22:55:08 UTC
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2726
[WIP] Float and Byte DataType support
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata float_support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2726
----
commit aca611a18070b1db61e66e011fc7064848d1f083
Author: kunal642 <ku...@...>
Date: 2018-09-14T09:56:10Z
added support for float data type
commit a4c976f77f2c40f334236b49e3949f66ea38c4e3
Author: kunal642 <ku...@...>
Date: 2018-09-16T22:52:55Z
addede support for byte type
----
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8642/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/345/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/393/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/348/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218110451
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java ---
@@ -140,6 +149,10 @@ private PrimitivePageStatsCollector(DataType dataType) {
minDouble = Double.POSITIVE_INFINITY;
maxDouble = Double.NEGATIVE_INFINITY;
decimal = 0;
+ } else if (dataType == DataTypes.FLOAT) {
+ minFloat = Float.MIN_VALUE;
--- End diff --
It should be reverse, please check other datatypes. minFloat should be Float.MAX_VALUE
---
[GitHub] carbondata pull request #2726: [CARBONDATA-2948] Float and Byte DataType sup...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218800702
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -61,7 +61,7 @@
protected static final boolean unsafe = Boolean.parseBoolean(CarbonProperties.getInstance()
.getProperty(CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE,
- CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE_DEFAULT));
+ "false"));
--- End diff --
reverted
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8613/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/525/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8571/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/534/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2726
retest this please
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/357/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218715201
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java ---
@@ -93,7 +93,22 @@ public double getDouble(int rowId) {
@Override
public float getFloat(int rowId) {
- throw new UnsupportedOperationException("internal error");
+ DataType dataType = columnPage.getDataType();
--- End diff --
okay
---
[GitHub] carbondata pull request #2726: [CARBONDATA-2948] Float and Byte DataType sup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2726
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218104702
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java ---
@@ -93,7 +93,22 @@ public double getDouble(int rowId) {
@Override
public float getFloat(int rowId) {
- throw new UnsupportedOperationException("internal error");
+ DataType dataType = columnPage.getDataType();
--- End diff --
Just call `getDouble(rowId)` from this method and then typecast it. No need to duplicate the code
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218715543
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoderMeta.java ---
@@ -132,6 +132,10 @@ private void writeMinMax(DataOutput out) throws IOException {
out.writeDouble((Double) getMaxValue());
out.writeDouble((Double) getMinValue());
out.writeDouble(0d); // unique value is obsoleted, maintain for compatibility
+ } else if (dataType == DataTypes.FLOAT) {
+ out.writeDouble((Float) getMaxValue());
--- End diff --
used writeFloat instead of writeDouble
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/301/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/476/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/326/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218109409
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ---
@@ -139,15 +139,15 @@ public void encode(int rowId, long value) {
@Override
public void encode(int rowId, float value) {
if (targetDataType == DataTypes.BYTE) {
- encodedPage.putByte(rowId, (byte) (value * factor));
+ encodedPage.putByte(rowId, (byte) (value * (float) factor));
--- End diff --
don't typecast it every time, take another float variable at class level
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/501/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8599/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/325/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/328/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/529/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8594/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2726
LGTM
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/366/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/522/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/354/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218715345
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java ---
@@ -140,6 +149,10 @@ private PrimitivePageStatsCollector(DataType dataType) {
minDouble = Double.POSITIVE_INFINITY;
maxDouble = Double.NEGATIVE_INFINITY;
decimal = 0;
+ } else if (dataType == DataTypes.FLOAT) {
+ minFloat = Float.MIN_VALUE;
--- End diff --
done
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8592/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218108240
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoderMeta.java ---
@@ -132,6 +132,10 @@ private void writeMinMax(DataOutput out) throws IOException {
out.writeDouble((Double) getMaxValue());
out.writeDouble((Double) getMinValue());
out.writeDouble(0d); // unique value is obsoleted, maintain for compatibility
+ } else if (dataType == DataTypes.FLOAT) {
+ out.writeDouble((Float) getMaxValue());
--- End diff --
Why not written in Float? Please written in float instead of double
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/472/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/297/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/504/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8603/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/352/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8542/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/356/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/347/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/533/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218790962
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -61,7 +61,7 @@
protected static final boolean unsafe = Boolean.parseBoolean(CarbonProperties.getInstance()
.getProperty(CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE,
- CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE_DEFAULT));
+ "false"));
--- End diff --
Please revert the change
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8546/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8572/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2726
@ravipesala Build is success
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8567/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8604/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/524/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2726
retest this please
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/502/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/321/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8621/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/497/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/373/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8574/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/543/
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/551/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8595/
---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/353/
---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218715267
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ---
@@ -139,15 +139,15 @@ public void encode(int rowId, long value) {
@Override
public void encode(int rowId, float value) {
if (targetDataType == DataTypes.BYTE) {
- encodedPage.putByte(rowId, (byte) (value * factor));
+ encodedPage.putByte(rowId, (byte) (value * (float) factor));
--- End diff --
added another variable for float
---
[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2726
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/572/
---