[GitHub] [hive] pvary commented on a change in pull request #2368: Fix column name issue with commas

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2368:
URL: https://github.com/apache/hive/pull/2368#discussion_r648146910



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -202,8 +204,11 @@ public static Schema readSchema(Configuration conf) {
   }
 
   public static String[] selectedColumns(Configuration conf) {
-    String[] readColumns = conf.getStrings(InputFormatConfig.SELECTED_COLUMNS);
-    return readColumns != null && readColumns.length > 0 ? readColumns : null;
+    String readColumns = conf.get(InputFormatConfig.SELECTED_COLUMNS);
+    if (readColumns == null) {

Review comment:
       The original code returned `null` for empty `readColumns` too. Are we ok with this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org