[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2885: da1469x: Add option to not disable watchdog on init

[GitBox <gi...@apache.org>]

kasjer commented on code in PR #2885:
URL: https://github.com/apache/mynewt-core/pull/2885#discussion_r980770674


##########
hw/mcu/dialog/da1469x/syscfg.yml:
##########
@@ -454,6 +454,11 @@ syscfg.defs:
         restrictions:
             - '!GPADC_BATTERY'
 
+    WATCHDOG_DISABLE_ON_INIT:
+        description: >
+          'Enable watchdog on init'
+        value: 1

Review Comment:
   Name **WATCHDOG_DISABLE_ON_INIT** is not really consistent with description. One can wander which one is true.
   Dialog freezing watchdog is quite unique future (usually when watchdog is enabled it's impossible to stop it till reset).
   I would name it rather more explicit like WATCHDOG_FREEZE_ON_INIT but that's just me (and I will not insist).
   But changing description to something like 'Freez watchdog on init, watchdog will be unfrozen by hal_watchdog_enable()' could be more descriptive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org