You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by m-revetria <gi...@git.apache.org> on 2014/04/30 21:42:53 UTC
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
GitHub user m-revetria opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/24
[iOS] Returns a specific error message when app has no access to Photos
If user cancel the UIImagePickerController and the app has no authorization to access to the Photos, an error with the message "has no access to assets" is returned as the plugin result.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m-revetria/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 5d79b38beec61ebe2d97af5e3187fd4f5027ac13
Author: RemeR <mi...@xmartlabs.com>
Date: 2014-04-29T15:30:50Z
[iOS] Returns a specific error message when app has no access to library.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-41855580
https://issues.apache.org/jira/browse/CB-6576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by m-revetria <gi...@git.apache.org>.
Github user m-revetria commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161976293
Hi, Nicolas.
The use case was show an alert message to the user indicating:
- If he canceled the selection of an image that he must select an image
in order to continue.
- If he canceled *due to the app has no access to the photos
library/camera*, then show an alert message to let the user knows the
app wasn't granted to access that resource.
That error could happen in the case where the user previously denied access
to camera roll and later he opens the camera to take a picture but he
cancels. In that case `[ALAssetsLibrary authorizationStatus] !=
ALAuthorizationStatusAuthorized`and the error "has no access to assets" is
returned wrongly.
I have solved this problem in commit:
https://github.com/m-revetria/cordova-plugin-camera/commit/bbdafb08640cafc8e98ed0cbd5d558ad9b6dc150
.
I didn't create a PR with this change yet.
Thanks!
[image: xmartlabs website] <http://xmartlabs.com/>
MIGUEL REVETRIA
iOS Engineer
_________________
<https://www.linkedin.com/in/mrevetria> <https://github.com/m-revetria>
On Thu, Dec 3, 2015 at 1:22 PM, Nicolas Leclerc <no...@github.com>
wrote:
> Hi, sorry to resurrect an old thread but i'm having trouble with this
> modification.
> When users click cancel in camera interface, we get a has no access to
> assets error instead of no image selected.
>
> @m-revetria <https://github.com/m-revetria> do you have more information
> about your use case ?
> I fail to see how this test is pertinent here.
> If user cancels action then it's just a cancellation, not a auth error.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161702527>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by nleclerc <gi...@git.apache.org>.
Github user nleclerc commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161702527
Hi, sorry to resurrect an old thread but i'm having trouble with this modification.
When users click cancel in camera interface, we get a `has no access to assets` error instead of `no image selected`.
@m-revetria do you have more information about your use case ?
I fail to see how this test is pertinent here.
If user cancels action then it's just a cancellation, not a auth error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by nleclerc <gi...@git.apache.org>.
Github user nleclerc commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161991834
Thanks for the answer.
Actually i was a bit confused because i came over the PR from another
commit, hence my question.
This new commit seems very nice, i hope it can be merged quickly ! :-)
On Fri, 4 Dec 2015 at 15:08 Miguel Revetria <no...@github.com>
wrote:
> Hi, Nicolas.
>
> The use case was show an alert message to the user indicating:
>
> - If he canceled the selection of an image that he must select an image
> in order to continue.
> - If he canceled *due to the app has no access to the photos
> library/camera*, then show an alert message to let the user knows the
> app wasn't granted to access that resource.
>
>
> That error could happen in the case where the user previously denied access
> to camera roll and later he opens the camera to take a picture but he
> cancels. In that case `[ALAssetsLibrary authorizationStatus] !=
> ALAuthorizationStatusAuthorized`and the error "has no access to assets" is
> returned wrongly.
>
> I have solved this problem in commit:
>
> https://github.com/m-revetria/cordova-plugin-camera/commit/bbdafb08640cafc8e98ed0cbd5d558ad9b6dc150
> .
>
> I didn't create a PR with this change yet.
>
> Thanks!
>
>
>
> [image: xmartlabs website] <http://xmartlabs.com/>
> MIGUEL REVETRIA
> iOS Engineer
> _________________
> <https://www.linkedin.com/in/mrevetria> <https://github.com/m-revetria>
>
> On Thu, Dec 3, 2015 at 1:22 PM, Nicolas Leclerc <no...@github.com>
> wrote:
>
> > Hi, sorry to resurrect an old thread but i'm having trouble with this
> > modification.
> > When users click cancel in camera interface, we get a has no access to
> > assets error instead of no image selected.
> >
> > @m-revetria <https://github.com/m-revetria> do you have more information
> > about your use case ?
> > I fail to see how this test is pertinent here.
> > If user cancels action then it's just a cancellation, not a auth error.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161702527
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161976293>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...
Posted by mazook <gi...@git.apache.org>.
Github user mazook commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-68299308
This does not seem to have been resolved.
Using org.apache.cordova.camera 0.3.4 on iOS 8.1.2, Cordova 4.1.2.
Could I be missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org