You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Stefano Bagnara (JIRA)" <ji...@apache.org> on 2008/09/13 12:32:44 UTC
[jira] Created: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
[javaflow] wrong expectations in failing junit tests (SimpleTestCase)
---------------------------------------------------------------------
Key: SANDBOX-254
URL: https://issues.apache.org/jira/browse/SANDBOX-254
Project: Commons Sandbox
Issue Type: Bug
Components: Javaflow
Reporter: Stefano Bagnara
The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635828#action_12635828 ]
Torsten Curdt commented on SANDBOX-254:
---------------------------------------
Stefano, could you compare with trunk. I had some problems applying the patch. I think things might have gotten messed up.
Actually since you are an Apache committer already and javaflow is still in sandbox you could also just get svn write access.
Please let me know.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635311#action_12635311 ]
Torsten Curdt commented on SANDBOX-254:
---------------------------------------
Argh! Of course ...it was too late last night - you are right :)
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Stefano Bagnara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated SANDBOX-254:
------------------------------------
Attachment: SANDBOX-254.diff
Here is a patch that fixes the expectations and also make 2 tests to pass.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Attachments: SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Stefano Bagnara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635843#action_12635843 ]
Stefano Bagnara commented on SANDBOX-254:
-----------------------------------------
The patch include 4 System.out removals from other classes (I left by mistake in SANDBOX-255 patch).
I'm not sure when i'll have further time to work on javaflow, so I don't know if it worth asking for write access, yet.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254-AbstractSimpleTestCase.java, SANDBOX-254-new.diff, SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Curdt resolved SANDBOX-254.
-----------------------------------
Resolution: Fixed
Should be obsolete by now. Should be covered by the new tests.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254-AbstractSimpleTestCase.java, SANDBOX-254-new.diff, SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Stefano Bagnara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated SANDBOX-254:
------------------------------------
Attachment: SANDBOX-254-AbstractSimpleTestCase.java
SANDBOX-254-new.diff
Attached a new diff and the final result for the AbstractSimpleTestCase class.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254-AbstractSimpleTestCase.java, SANDBOX-254-new.diff, SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Curdt closed SANDBOX-254.
---------------------------------
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254-AbstractSimpleTestCase.java, SANDBOX-254-new.diff, SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Stefano Bagnara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635309#action_12635309 ]
Stefano Bagnara commented on SANDBOX-254:
-----------------------------------------
@Torsten: I don't understand. Isn't Continuation.continueWith(c) return NULL when the process is completed and no more continuations are available? Otherwise continuations would never complete... Am I missing anything?
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANDBOX-254) [javaflow] wrong expectations in
failing junit tests (SimpleTestCase)
Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635269#action_12635269 ]
Torsten Curdt commented on SANDBOX-254:
---------------------------------------
Hmm ...this does not make any sense
{code}
c = Continuation.continueWith(c);
- assertTrue(c != null);
+ assertTrue(c == null);
{code}
Continuation.continueWith(c); should ALWAYS return a continuation.
Will need to have a closer look at the patch.
> [javaflow] wrong expectations in failing junit tests (SimpleTestCase)
> ---------------------------------------------------------------------
>
> Key: SANDBOX-254
> URL: https://issues.apache.org/jira/browse/SANDBOX-254
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Javaflow
> Reporter: Stefano Bagnara
> Assignee: Torsten Curdt
> Attachments: SANDBOX-254.diff
>
>
> The SimpleTestCase is currently failing but IMHO it expects the wrong results and do wrong assertions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.