You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "dominikriemer (via GitHub)" <gi...@apache.org> on 2023/10/21 20:55:05 UTC
[PR] refactor: Add individual connector modules for adapters and sinks
dominikriemer opened a new pull request, #2069:
URL: https://github.com/apache/streampipes/pull/2069
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
For better organization and to facilitate code reuse among adapters and sinks, I moved some adapters and sinks to their own module:
* Kafka adapter and sink to `streampipes-connectors-kafka`
* Pulsar adapter and sink to `streampipes-connectors-pulsar`
* TubeMQ adapter and sink to `streampipes-connectors-tubemq`
* RocketMQ adapter and sink to `streampipes-connectors-rocketmq`.
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add individual connector modules for adapters and sinks
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on code in PR #2069:
URL: https://github.com/apache/streampipes/pull/2069#discussion_r1367858005
##########
streampipes-extensions/streampipes-sinks-brokers-jvm/src/main/java/org/apache/streampipes/sinks/brokers/jvm/BrokersJvmInit.java:
##########
@@ -54,16 +50,12 @@ public SpServiceDefinition provideServiceDefinition() {
"",
8096)
.registerPipelineElements(
- new KafkaPublishSink(),
new JmsPublisherSink(),
new RestSink(),
new BufferRestPublisherSink(),
new RabbitMqPublisherSink(),
new MqttPublisherSink(),
new WebsocketServerSink(),
- new PulsarPublisherSink(),
- new RocketMQPublisherSink(),
Review Comment:
Yes, I added these to `extensions-all-iiot` so that we don't need the dependency in the broker module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add individual connector modules for adapters and sinks
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer merged PR #2069:
URL: https://github.com/apache/streampipes/pull/2069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add individual connector modules for adapters and sinks
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #2069:
URL: https://github.com/apache/streampipes/pull/2069#discussion_r1367845574
##########
streampipes-extensions/streampipes-sinks-brokers-jvm/src/main/java/org/apache/streampipes/sinks/brokers/jvm/BrokersJvmInit.java:
##########
@@ -54,16 +50,12 @@ public SpServiceDefinition provideServiceDefinition() {
"",
8096)
.registerPipelineElements(
- new KafkaPublishSink(),
new JmsPublisherSink(),
new RestSink(),
new BufferRestPublisherSink(),
new RabbitMqPublisherSink(),
new MqttPublisherSink(),
new WebsocketServerSink(),
- new PulsarPublisherSink(),
- new RocketMQPublisherSink(),
Review Comment:
Don't we want them to be part of the brokers collection anymore? Or do we not want to have the additional dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org