[GitHub] storm pull request #1352: STORM-1723 (1.x) Introduce ClusterMetricsConsumer

[harshach <gi...@git.apache.org>]

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1352#discussion_r65499161
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
    @@ -1355,48 +1366,843 @@
     (defmethod blob-sync :local [conf nimbus]
       nil)
     
    -(defserverfn service-handler [conf inimbus]
    -  (.prepare inimbus conf (master-inimbus-dir conf))
    -  (log-message "Starting Nimbus with conf " conf)
    -  (let [nimbus (nimbus-data conf inimbus)
    -        blob-store (:blob-store nimbus)
    -        principal-to-local (AuthUtils/GetPrincipalToLocalPlugin conf)
    +(defn extract-cluster-metrics [^ClusterSummary summ]
    --- End diff --
    
    since we are doing this in ui isn't it better move it to helpers or utils and import that here in nimbus


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---