You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/10 17:23:58 UTC
Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
Bugs: AMBARI-13817
https://issues.apache.org/jira/browse/AMBARI-13817
Repository: ambari
Description
-------
It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
Specifically the missing parts are:
export SERVICE=$SERVICE
if [ "$SERVICE" = "metastore" ]; then
export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
else
export HADOOP_HEAPSIZE="{{hive_heapsize}}"
fi
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
Diff: https://reviews.apache.org/r/40141/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review106042
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Лис. 11, 2015, 12:15 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
>
> (Updated Лис. 11, 2015, 12:15 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13817
> https://issues.apache.org/jira/browse/AMBARI-13817
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
> export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
> export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
>
> Diff: https://reviews.apache.org/r/40141/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review106049
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Nov. 11, 2015, 12:15 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 12:15 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13817
> https://issues.apache.org/jira/browse/AMBARI-13817
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
> export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
> export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
>
> Diff: https://reviews.apache.org/r/40141/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/
-----------------------------------------------------------
(Updated Ноя. 11, 2015, 12:15 п.п.)
Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
Bugs: AMBARI-13817
https://issues.apache.org/jira/browse/AMBARI-13817
Repository: ambari
Description
-------
It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
Specifically the missing parts are:
export SERVICE=$SERVICE
if [ "$SERVICE" = "metastore" ]; then
export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
else
export HADOOP_HEAPSIZE="{{hive_heapsize}}"
fi
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
Diff: https://reviews.apache.org/r/40141/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Ноя. 10, 2015, 5:08 п.п., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml, line 40
> > <https://reviews.apache.org/r/40141/diff/1/?file=1121872#file1121872line40>
> >
> > Could we have remove the content property from HDP-2.3 if its the same as the one in 2.2?
https://reviews.apache.org/r/40141/
[19:24:44] Ivan Kozlov(CV Ambari Server team): They are different. hive-env for 2.3 has following code, which is absent in hive-env 2.2:
{% if sqla_db_used or lib_dir_available %}
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:{{jdbc_libs_dir}}"
export JAVA_LIBRARY_PATH="$JAVA_LIBRARY_PATH:{{jdbc_libs_dir}}"
{% endif %}
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review105897
-----------------------------------------------------------
On Ноя. 10, 2015, 4:23 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
>
> (Updated Ноя. 10, 2015, 4:23 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13817
> https://issues.apache.org/jira/browse/AMBARI-13817
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
> export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
> export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
>
> Diff: https://reviews.apache.org/r/40141/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review105897
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml (line 40)
<https://reviews.apache.org/r/40141/#comment164593>
Could we have remove the content property from HDP-2.3 if its the same as the one in 2.2?
- Sumit Mohanty
On Nov. 10, 2015, 4:23 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 4:23 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13817
> https://issues.apache.org/jira/browse/AMBARI-13817
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
> export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
> export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
>
> Diff: https://reviews.apache.org/r/40141/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40141: HDP-2.3 does not have the ability to set
heapsize for hive components
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40141/#review105903
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (lines 781 - 783)
<https://reviews.apache.org/r/40141/#comment164597>
Here you are using cluster.getDesiredConfigByType(HIVE_ENV_CONFIG) twice, i think it will be better to get once and use twice.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 792)
<https://reviews.apache.org/r/40141/#comment164598>
We have a constant for "content" property
- Vitalyi Brodetskyi
On Лис. 10, 2015, 4:23 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40141/
> -----------------------------------------------------------
>
> (Updated Лис. 10, 2015, 4:23 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13817
> https://issues.apache.org/jira/browse/AMBARI-13817
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It could be as simple as making sure that ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml has the same changes as in the 2.2. version (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml).
> Specifically the missing parts are:
> export SERVICE=$SERVICE
> if [ "$SERVICE" = "metastore" ]; then
> export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}"
> else
> export HADOOP_HEAPSIZE="{{hive_heapsize}}"
> fi
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 447993d
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml c331802
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml 30141c6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
>
> Diff: https://reviews.apache.org/r/40141/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>