You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/08/03 13:25:58 UTC

[GitHub] spark pull request #21975: [SPARK-25001][BUILD] Fix miscellaneous build warn...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21975#discussion_r207542952
  
    --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/test/Complex.java ---
    @@ -676,7 +676,7 @@ public int compareTo(Complex other) {
         }
     
         int lastComparison = 0;
    -    Complex typedOther = (Complex)other;
    +    Complex typedOther = other;
    --- End diff --
    
    I hadn't touched code that seemed to be copied from Hive (it generates a ton of warnings) but think it's fine to make this change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org